{{ message }}
ROS - All sensors and car support#2743
Merged
Merged
Conversation
support ENU for all car frames
rajat2004
reviewed
Jun 3, 2020
rajat2004
left a comment
rajat2004
left a comment
Contributor
There was a problem hiding this comment.
This will be a great improvement to the ROS wrapper, thanks!
Can you add some details about the new sensor publishers, etc in airsim_ros_pkgs.md
Just a light lookover, will try to test it out soon
Author
|
Should be all set for merge. Let me know if you see any other issues. |
|
nice work on the car interface. I found 1 little issue: Naming the car anything other than drone_1 means no control api, because the ros interface is looking for /airsim_node/drone_1/car_cmd and this is hard-coded. This is not a big deal though if you mention it in the documentation. Would be great to see this addition on the main branch. |
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many improvements to ROS package "airsim_ros_pkgs"