iframe-proxy

tbouffard · 2025-11-06T10:45:10Z

Do the update everywhere except in the "html" package which requires an older version (because of storybook v7).

Summary by CodeRabbit

Chores
- Updated build tool versions across TypeScript example packages.

Except in the "html" package which requires an older version (because of storybook v7).

coderabbitai · 2025-11-06T10:45:35Z

Walkthrough

Vite devDependency updated from ~6.3.5 to ~7.2.1 across three TypeScript example package.json files. No logic, scripts, or other dependencies modified.

Changes

Cohort / File(s)	Summary
Vite version bump `packages/ts-example-selected-features/package.json`, `packages/ts-example-without-defaults/package.json`, `packages/ts-example/package.json`	Bumped vite devDependency from ~6.3.5 to ~7.2.1

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

chore(deps-dev): bump vite from 6.0.7 to 6.2.0 #697: Modifies the same vite devDependency in the same ts-example package.json files
chore(deps-dev): bump vite and test dependencies #617: Updates vite dependency across ts-example packages with related version bumping pattern
chore(deps-dev): bump vite from 6.2.0 to 6.3.5 #813: Modifies vite version in the same ts-example package files with prior version bump history

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided, but the template requires an overview section explaining what and why the change is being made, issue references, and other required checklist items.	Add a pull request description following the provided template, including an overview of why the Vite version bump is necessary, any relevant issue references, and completion of the PR checklist.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: bumping the Vite dev dependency from version 6.3.5 to 7.2.1 across multiple packages.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/bump_vite

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43b8194 and 353fea8.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

packages/ts-example-selected-features/package.json (1 hunks)
packages/ts-example-without-defaults/package.json (1 hunks)
packages/ts-example/package.json (1 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json (~5.8.2) and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` commands because the TypeScript dependency is hoisted in the monorepo structure.

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` because it's available through this hoisted dependency in the monorepo structure.

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 617
File: packages/ts-example/package.json:12-12
Timestamp: 2025-01-05T15:35:57.645Z
Learning: We keep Vite 5 specifically in the package that uses Storybook (the "html" package), while the other packages can safely use a newer version of Vite without compatibility issues.

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 791
File: packages/ts-example/vite.config.js:30-30
Timestamp: 2025-04-29T13:25:31.494Z
Learning: In the maxGraph project, each example package (ts-example, ts-example-selected-features, ts-example-without-defaults) implements different use cases with varying features, resulting in different application sizes. Therefore, each package has its own specific chunkSizeWarningLimit value in its vite.config.js file, calibrated to its expected bundle size.

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 849
File: packages/html/stories/DragSource.stories.js:98-101
Timestamp: 2025-06-13T07:48:10.300Z
Learning: User tbouffard prefers answers in English; avoid switching to other languages in future replies.

📚 Learning: 2025-04-22T16:34:40.309Z

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json (~5.8.2) and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` commands because the TypeScript dependency is hoisted in the monorepo structure.

Applied to files:

packages/ts-example/package.json
packages/ts-example-without-defaults/package.json
packages/ts-example-selected-features/package.json

📚 Learning: 2025-01-05T15:35:57.645Z

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 617
File: packages/ts-example/package.json:12-12
Timestamp: 2025-01-05T15:35:57.645Z
Learning: We keep Vite 5 specifically in the package that uses Storybook (the "html" package), while the other packages can safely use a newer version of Vite without compatibility issues.

Applied to files:

packages/ts-example/package.json
packages/ts-example-without-defaults/package.json
packages/ts-example-selected-features/package.json

📚 Learning: 2025-04-29T13:25:31.494Z

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 791
File: packages/ts-example/vite.config.js:30-30
Timestamp: 2025-04-29T13:25:31.494Z
Learning: In the maxGraph project, each example package (ts-example, ts-example-selected-features, ts-example-without-defaults) implements different use cases with varying features, resulting in different application sizes. Therefore, each package has its own specific chunkSizeWarningLimit value in its vite.config.js file, calibrated to its expected bundle size.

Applied to files:

packages/ts-example/package.json
packages/ts-example-without-defaults/package.json
packages/ts-example-selected-features/package.json

📚 Learning: 2025-04-22T16:34:40.309Z

Learnt from: tbouffard
Repo: maxGraph/maxGraph PR: 774
File: packages/ts-example-selected-features/package.json:11-13
Timestamp: 2025-04-22T16:34:40.309Z
Learning: In the maxGraph project, TypeScript is defined as a dependency in the root package.json and not in individual package.json files for example packages. The build scripts in example packages can use `tsc` because it's available through this hoisted dependency in the monorepo structure.

Applied to files:

packages/ts-example/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: build
GitHub Check: build (ubuntu-24.04)
GitHub Check: build (windows-2022)
GitHub Check: build (macos-14)

🔇 Additional comments (3)

packages/ts-example-without-defaults/package.json (1)

12-12: Vite 7.2.1 migration is consistently applied across all three example packages; runtime testing required.

All three packages reference vite ~7.2.1 consistently, and their vite.config.js files use standard, compatible Vite APIs (defineConfig, build.rollupOptions, build.chunkSizeWarningLimit). However, verify before merge:

Comprehensive testing of build, dev, and preview workflows across all three packages completed.

No regressions in bundle sizes or build performance observed.

packages/ts-example/package.json (1)

12-12: Verify build output and chunkSizeWarningLimit with Vite 7.2.1.

The vite.config.js is compatible with Vite 7—it doesn't use any removed APIs. However, Vite 7 changes the default build.target from "modules" to "baseline-widely-available", which affects transpilation output and may impact bundle size. Per learnings from PR #791, the chunkSizeWarningLimit: 436 is calibrated to the expected bundle size. Verify:

Build and preview scripts execute without errors.

Bundle size remains acceptable under the new transpilation target.

Adjust chunkSizeWarningLimit if needed to match the new bundle size.

Also confirm Node.js version compatibility (Vite 7 requires Node 20.19+ or 22.12+).

packages/ts-example-selected-features/package.json (1)

12-12: Vite 7.2.1 upgrade verified across all example packages.

Verification confirms:

✓ All three vite.config.js files are compatible with Vite 7.2.1 (using only stable APIs: defineConfig, manualChunks, chunkSizeWarningLimit)

✓ Build and preview workflows use standard Vite patterns compatible with v7

✓ chunkSizeWarningLimit values remain appropriate and properly calibrated per package (436, 370, 310)

✓ Node.js version (Node 20 per .nvmrc) meets Vite 7 requirement (20.19+)

✓ No breaking changes from Vite 6→7 affect these configs

All three packages upgraded consistently to ~7.2.1 without issues.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2025-11-06T10:46:12Z

chore(deps-dev): bump vite from 6.3.5 to 7.2.1

353fea8

Except in the "html" package which requires an older version (because of storybook v7).

tbouffard added dependencies skip-changelog Do not include in Changelog and Release Notes javascript Pull requests that update Javascript code labels Nov 6, 2025

tbouffard merged commit 2ade732 into main Nov 6, 2025
7 checks passed

tbouffard deleted the chore/bump_vite branch November 6, 2025 10:52

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps-dev): bump vite from 6.3.5 to 7.2.1#941

chore(deps-dev): bump vite from 6.3.5 to 7.2.1#941
tbouffard merged 1 commit into
mainfrom
chore/bump_vite

tbouffard commented Nov 6, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

tbouffard commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Pre-merge checks and finishing touches

Uh oh!

sonarqubecloud Bot commented Nov 6, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tbouffard commented Nov 6, 2025 •

edited

Loading

coderabbitai Bot commented Nov 6, 2025 •

edited

Loading