chore(deps-dev): bump vite and test dependencies by tbouffard · Pull Request #617 · maxGraph/maxGraph · GitHub
Skip to content

chore(deps-dev): bump vite and test dependencies#617

Merged
tbouffard merged 2 commits into
mainfrom
chore/bump_vite_and_test_deps
Jan 5, 2025
Merged

chore(deps-dev): bump vite and test dependencies#617
tbouffard merged 2 commits into
mainfrom
chore/bump_vite_and_test_deps

Conversation

@tbouffard

@tbouffard tbouffard commented Jan 3, 2025

Copy link
Copy Markdown
Member

Keep vite v5 in the storybook package as vite v6 is not marked as supported by storybook v7.

Summary by CodeRabbit

  • Dependency Updates
    • Updated @swc/core from ~1.7.26 to ~1.10.4 in @maxgraph/core
    • Updated @swc/jest from ~0.2.36 to ~0.2.37 in @maxgraph/core
    • Updated vite from ~5.4.11 to ~6.0.7 in @maxgraph/ts-example-vite projects

Keep vite v5 in the storybook package as vite v6 is not marked as supported by storybook v7.
@tbouffard tbouffard added dependencies skip-changelog Do not include in Changelog and Release Notes javascript Pull requests that update Javascript code labels Jan 3, 2025
@coderabbitai

coderabbitai Bot commented Jan 3, 2025

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2c363c and e4a65e5.

📒 Files selected for processing (3)
  • packages/core/package.json (1 hunks)
  • packages/ts-example-without-defaults/package.json (1 hunks)
  • packages/ts-example/package.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Generate website
packages/ts-example/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/ts-example-without-defaults/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/core/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

🪛 GitHub Actions: Build
packages/ts-example/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/ts-example-without-defaults/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

packages/core/package.json

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

🔇 Additional comments (1)
packages/core/package.json (1)

52-53: Verify SWC compatibility with current Jest version

The updates to @swc/core and @swc/jest look reasonable, but please ensure compatibility with the current Jest version (29.7.0).

Run the following to verify compatibility and fix sync issues:

After verifying, run npm install to sync package-lock.json with package.json.

✅ Verification successful

Let me gather more information about Jest compatibility.


Let me check the Jest configuration in the workspace packages.


Let me try one final check to locate Jest configuration.


SWC dependencies update looks compatible and safe

The verification shows:

  • @swc/jest has a flexible peer dependency on @swc/core (*)
  • @swc/core only requires @swc/helpers as a peer dependency
  • Jest tests are configured in the package and run via jest --runInBand
  • No explicit SWC transformer configuration was found, suggesting default configuration

The minor version updates to both SWC packages are compatible with each other and should work with the current Jest setup.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check compatibility between @swc packages and Jest

# Check if these versions are commonly used together
npm info @swc/jest@0.2.37 peerDependencies
npm info @swc/core@1.10.4 peerDependencies

# Verify no known issues exist
npm view @swc/jest@0.2.37 bugs.url
npm view @swc/core@1.10.4 bugs.url

Length of output: 293


Script:

#!/bin/bash
# Check Jest version and its dependencies
cat package.json | jq '.dependencies.jest, .devDependencies.jest'

# Search for Jest configuration files and SWC transformer setup
fd -e js -e json -e ts --full-path '.*jest.*config.*' -X cat

# Look for any existing SWC configuration
fd -e json -e js '.swcrc' -X cat

Length of output: 173


Script:

#!/bin/bash
# Check Jest configuration in workspace packages
fd -g 'packages/*/package.json' -X cat {} \; | jq -c 'select(.dependencies.jest != null or .devDependencies.jest != null) | {name: .name, jest: (.dependencies.jest // .devDependencies.jest)}'

# Look for Jest config files in packages
fd -g 'packages/*/jest.config.*' -X echo "=== {} ===" \; -X cat {}

Length of output: 268


Script:

#!/bin/bash
# Check core package.json for Jest and test configurations
cat packages/core/package.json | jq '.scripts | select(.test != null or .jest != null)'

# Look for any test scripts or configurations
rg -g '!node_modules' -g '!dist' -l 'transform.*swc' --type js --type json --type ts

Length of output: 426

🧰 Tools
🪛 GitHub Actions: Generate website

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

🪛 GitHub Actions: Build

[error] Package.json and package-lock.json are out of sync. Multiple package version mismatches including @swc/core (1.7.26 vs 1.10.4), @swc/jest (0.2.36 vs 0.2.37), and missing packages like vite@6.0.7 and yaml@2.7.0

Comment thread packages/ts-example/package.json
Comment thread packages/ts-example-without-defaults/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant