Add boxplot params to rctemplate by phobson · Pull Request #5526 · matplotlib/matplotlib · GitHub
Skip to content

Add boxplot params to rctemplate - #5526

Merged
tacaswell merged 2 commits into
matplotlib:masterfrom
phobson:add-bxpparams-to-rctemplate
Nov 20, 2015
Merged

tacaswell merged 2 commits into
matplotlib:masterfrom
phobson:add-bxpparams-to-rctemplate

Conversation

@phobson

@phobson phobson commented Nov 19, 2015

Copy link
Copy Markdown
Member

Also flailing here.

Part of the work that goes with #5523.

Aims to close #5441

@WeatherGod

Copy link
Copy Markdown
Member

@mdboom

mdboom commented Nov 20, 2015

Copy link
Copy Markdown
Member

They are already in the classic style, though I discovered a bug in them yesterday. boxplot.flierprops.linestyle was copied incorrectly from the old default in rcsetup.py. This causes tests to fail when you decrease the tolerance down to 0.

@phobson: Maybe you could make this change here as well?

diff --git a/lib/matplotlib/mpl-data/stylelib/classic.mplstyle b/lib/matplotlib/mpl-data/stylelib/classic.mplstyle
index 0f61a53..86b4c22 100644
--- a/lib/matplotlib/mpl-data/stylelib/classic.mplstyle
+++ b/lib/matplotlib/mpl-data/stylelib/classic.mplstyle
@@ -322,11 +322,11 @@ boxplot.capprops.color: k
 boxplot.capprops.linestyle: -
 boxplot.capprops.linewidth: 1.0
 boxplot.flierprops.color: b
-boxplot.flierprops.linestyle: -
+boxplot.flierprops.linestyle: none
 boxplot.flierprops.linewidth: 1.0
 boxplot.flierprops.marker: +
 boxplot.flierprops.markeredgecolor: k

@tacaswell tacaswell added this to the next major release (2.0) milestone Nov 20, 2015
@phobson

phobson commented Nov 20, 2015

Copy link
Copy Markdown
Member Author

@mdboom done! that explains why my result images in default boxplot style PR were so o_0

@phobson

phobson commented Nov 20, 2015

Copy link
Copy Markdown
Member Author

Ok, I've confirmed that #5523 depends on this to produce meaningful test images

tacaswell added a commit that referenced this pull request Nov 20, 2015
@tacaswell
tacaswell merged commit 0834f7e into matplotlib:master Nov 20, 2015
@phobson
phobson deleted the add-bxpparams-to-rctemplate branch November 20, 2015 22:19
@phobson phobson changed the title WIP: Add boxplot params to rctemplate Add boxplot params to rctemplate Nov 20, 2015
tacaswell added a commit that referenced this pull request Nov 20, 2015
@tacaswell

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boxplot rcParams are not in matplotlibrc.template

4 participants