{{ message }}
Conversation
Member
Member
|
Thanks. This for the most part looks good. The only change I would suggest is that instead of hardcoding |
phobson
force-pushed
the
default-boxplot-style
branch
2 times, most recently
from
December 14, 2015 18:56
922eef6 to
50e5ccb
Compare
phobson
force-pushed
the
default-boxplot-style
branch
from
February 18, 2016 23:34
50e5ccb to
6101982
Compare
Member
|
ping @phobson The color cycle color selector is now merged (as |
Member
Author
|
thanks. @tacaswell. should I rebase off of master or 2.x? |
Member
|
as this PR is against master, rebase on master |
Going for the Spinal Tap approach. Q: How much blacker could the boxplots be? A: A little, actually. I left some color in the median line.
It was just "blue". Now it's [0] to pick out the first color from the existing color cycle, whatever that may be.
phobson
force-pushed
the
default-boxplot-style
branch
from
April 28, 2016 16:00
6101982 to
11818d0
Compare
Member
|
Looks like the image tests are not using the classic style so we will need to also update the test images or switch the boxplot image tests to use the classic style. |
Member
Author
|
prefixed b2c8cca as "WIP" since:
I've add some TODO's to the original message up top |
Member
Author
|
Just the test images: |
Member
|
Locally I am seeing |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I'm sort of flailing around at the moment.
Not exactly sure how you want the defaults modified. I just took at crack at the rcParams that are currently (see #5441) available.
bxpandboxplot