Correctly handle invalid PNG metadata. by QuLogic · Pull Request #13923 · matplotlib/matplotlib · GitHub
Skip to content

Correctly handle invalid PNG metadata. - #13923

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
QuLogic:png-metadata-crash
Apr 11, 2019
Merged

dstansby merged 1 commit into
matplotlib:masterfrom
QuLogic:png-metadata-crash

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 11, 2019

Copy link
Copy Markdown
Member

PR Summary

Fix the crash in #13902 due to invalid metadata. Not sure if I should bother with a test since #13902 will exercise it.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch.

@dstansby dstansby added this to the v3.2.0 milestone Apr 11, 2019
@dstansby
dstansby merged commit f26774c into matplotlib:master Apr 11, 2019
@QuLogic
QuLogic deleted the png-metadata-crash branch April 12, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants