Add support for metadata= and pil_kwargs= in imsave(). by anntzer · Pull Request #13902 · matplotlib/matplotlib · GitHub
Skip to content

Add support for metadata= and pil_kwargs= in imsave(). - #13902

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
anntzer:imsavemetadatapilkwargs
May 6, 2019
Merged

dstansby merged 1 commit into
matplotlib:masterfrom
anntzer:imsavemetadatapilkwargs

Conversation

@anntzer

@anntzer anntzer commented Apr 7, 2019

Copy link
Copy Markdown
Contributor

For consistency with savefig().

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer

anntzer commented Apr 7, 2019

Copy link
Copy Markdown
Contributor Author

@tacaswell tacaswell added this to the v3.2.0 milestone Apr 11, 2019
@tacaswell

Copy link
Copy Markdown
Member

"crashed" sounds like segfault not an exception. Nothing jump out at me either....

@QuLogic

QuLogic commented Apr 11, 2019

Copy link
Copy Markdown
Member

The problem is that the original path replaces None with an empty dictionary (+ the Software key), but this new one doesn't. The C code doesn't expect or handle None, or even non-dictionary types.

@anntzer

anntzer commented Apr 11, 2019

Copy link
Copy Markdown
Contributor Author

@QuLogic thanks, your patch fixed this PR :)

Comment thread doc/api/next_api_changes/2019-04-05-AL.rst
@anntzer
anntzer force-pushed the imsavemetadatapilkwargs branch from d641704 to 5e91c5a Compare April 16, 2019 13:08
@dstansby

dstansby commented May 6, 2019

Copy link
Copy Markdown
Member

@dstansby
dstansby merged commit 79c296c into matplotlib:master May 6, 2019
@anntzer
anntzer deleted the imsavemetadatapilkwargs branch May 6, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants