feat: add GitHub Alerts creation and conversion menus by Jocs · Pull Request #5771 · marktext/marktext · GitHub
Skip to content

feat: add GitHub Alerts creation and conversion menus - #5771

Merged
Jocs merged 41 commits into
developfrom
feat/github-alerts-menus
Oct 17, 2026
Merged

Jocs merged 41 commits into
developfrom
feat/github-alerts-menus

Conversation

@Jocs

@Jocs Jocs commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Builds on merged #5774, #5775 and #5776. Part 4/4 of GitHub Alerts support, split from #5765 and #5770.

Closes #3764. Closes #1240 (GitHub Alerts portion).

Summary

Expose the GitHub Alerts foundation from #5775 through the Paragraph menu, paragraph front menu and Quick Insert. This PR targets develop; its diff contains only menu integration and related tests/translations.

  • Add the five types to the application Paragraph submenu when the setting is enabled, without new shortcuts. Update checked/enabled state from the editor selection.
  • Add creation and conversion entries to the paragraph front menu and Quick Insert, including readable icons and localized descriptions.
  • Hide alert entries while disabled or in unsupported nested contexts.
  • Complete menu translations for all 12 locales, retaining the canonical NOTE/TIP/IMPORTANT/WARNING/CAUTION syntax identifiers.
  • Keep native application-menu and browser menu E2E separate from core parsing, rendering and export tests.

Validation

  • Application integration and locale validation: 59 unit tests passed.
  • Alert typing, menu interactions and paragraph-front regressions: 20 Chromium E2E passed.
  • Native application-menu, alert export, paragraph-menu and Quick Insert E2E: 5 passed.
  • Desktop/Muya lint, full type checks and build:unpack passed.
  • The diff contains only menu integration layered on the preceding editor and desktop PRs.

Review order

#5774 (syntax/conversion) → #5775 (editor behavior) → #5776 (desktop integration) → this PR (menus).

All three predecessors are merged. This branch is synchronized with develop.

Existing screenshot evidence and discussion are preserved in #5765. No requirements documents or screenshots are committed.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Jocs added 21 commits October 17, 2026 17:18
@Jocs
Jocs changed the base branch from feat/github-alerts-core to feat/github-alerts-desktop October 17, 2026 13:51
@Jocs
Jocs changed the base branch from feat/github-alerts-desktop to develop October 17, 2026 14:56
@Jocs
Jocs merged commit 89de804 into develop Oct 17, 2026
18 checks passed
@Jocs Jocs mentioned this pull request Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for GitHub Alerts Callouts (success, info, warning, danger)

1 participant