{{ message }}
Merged
Conversation
Member
Author
Contributor
|
I'll wait until #30 is safe to merge before merging this one. Thanks. |
Contributor
|
Feel free to rebase then open the PR. |
I checked, but as far back as the docs for 1.1, the docs say you should call free.
As indicated by SSL_CTRL_OPTIONS no longer being defined, we should avoid it as much as possible.
So now the source just contains an in-order list, which is a lot more legible.
Member
Author
|
I did notice the CI job only builds and tests with openssl 1.1, because it uses ubuntu 20.04. |
Member
|
I'm a little unsure about bumping CI to 22.04 because love 11's appimage is compiled with 20.04. Anyone have opinions? |
Member
|
Maybe we could run two linux jobs (20.04 versus 22.04) and label their artifacts appropriately. That might not be useful for very long though. |
Contributor
|
Since we're only runtime loading OpenSSL3, I wonder if it's good idea to clone OpenSSL source code locally then use the include for it? This would require more modification to lua-https CMake and we'll eventually need Ubuntu 22.04 for testing it anyway. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
Based on the first commit of #30.
The only actual breakage was the rename of
SSL_get_peer_certificatetoSSL_get1_peer_certificate.I had spotted a new HTTP client in OpenSSL3, and tried to get that to work.
Unfortunately, it's too limited for our purposes: it only supports GET and POST, and has no way to retrieve the status code or response headers.