Selectable library loaders, including link-time#30
Conversation
Makes it easier to replace, centralises the platform-dependent logic, and means we can more easily re-use things like the templated LoadSymbol.
Which does not call dlsym or equivalents, but links directly against the library and dispatches on name. This can be useful on platforms without (working) dlsym-implementations, without affecting the structure of lua-https too much.
Apparently on macOS we weren't building using c++11, causing a compile error because of a nullptr. Considering the ubiquitous support for c++11 these days, just enable it.
|
I see you’ve set LIBRARY_LOADER, but that is a cmake-only variable. Is the define HTTPS_LIBRARY_LOADER_LINKTIME set? Otherwise LinktimeLibraryLoader.cpp will be ifdeffed out. |
|
Ah, gotcha.. didn't see that part of it. It built the 3DS binary, will check if this works shortly. |
|
Alright, it kind of works. I got the following error, which I vaguely remember how I solved it last time, but I'm not 100% sure. If memory serves it failed the connection test. I might be misremembering, though? The version of cURL we have uses certificates that are placed on the SD Card, but I doubt it's expired by now, but I can also check that. |
|
Digging further, it's not even enabling cURL as a backend: HTTPSClient::Reply request(const HTTPSClient::Request& req)
{
std::printf("request\n");
for (size_t i = 0; clients[i]; ++i)
{
HTTPSClient& client = *clients[i];
std::printf("client.valid()? %d\n", client.valid());
if (client.valid())
return client.request(req);
}
throw std::runtime_error("No applicable HTTPS implementation found");
}This doesn't even print inside the for loop. I'm sure I missed something stupid, going to check the source a bit closer to see what it might be. |
MikuAuahDark
left a comment
MikuAuahDark
left a comment
There was a problem hiding this comment.
In overall, I think it looks good to me.
3 participants
Resolves #16, as per my proposal there. Alternative to #22.
I wanted to do the first commit for OpenSSL 3 support anyway, and it provided an alternative solution for #16. It does feel slightly more invasive than I'd like.
@TurtleP can you check whether this works for you?