Publish verified pipe-flow diagnostics with actual bisection animation by khalil-official · Pull Request #1 · khalil-official/pipeflow-bench · GitHub
Skip to content

Publish verified pipe-flow diagnostics with actual bisection animation - #1

Merged
khalil-official merged 3 commits into
mainfrom
results/verification-suite
Oct 18, 2026
Merged

khalil-official merged 3 commits into
mainfrom
results/verification-suite

Conversation

@khalil-official

@khalil-official khalil-official commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Pipeflow Bench now reports convergence only when its requested Colebrook residual tolerance is met, and rejects invalid roughness before selecting any flow regime. The result presentation uses recorded solver probes and correct numerical plot coordinates.

  • Fix the reproduced width-stop false success at Re=1e7 and NaN-roughness success in the transition band. Validate tolerances, budgets, friction factors, array laminar inputs and derived finite results. Expose unsuccessful budget/stagnation outcomes honestly.
  • Add a reusable trace API with actual pre-probe brackets, midpoints and residuals; retain the existing three-value solver return contract.
  • Replace the animation with all 43 real iterations in two panels. Fix the Haaland comparison's Reynolds axis, restrict Blasius to its documented domain, and show all three regimes in a 100-point pressure sweep with a low-speed detail panel.
  • All 39 tests pass locally. Regenerate white/no-grid GIF/PNG/SVG outputs and save trace, tolerance-regression, comparison and pressure-sweep CSVs. Correct the worked operating-point friction factor to 0.0225314 and expand numerical-contract documentation.

Validation solves the empirical equation and checks analytic/hand-computed anchors; it does not establish experimental correlation accuracy. Existing main history and calendar disclosure are preserved.

Copilot AI balanced review requested due to automatic review settings October 17, 2026 22:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@khalil-official khalil-official changed the title Add reproducible benchmark suite, animation, and technical guides Publish verified pipe-flow diagnostics with actual bisection animation Oct 18, 2026
@khalil-official
khalil-official merged commit 71ea927 into main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants