{{ message }}
Repository navigation
Refactor: Extract shared logic in AppCache (Fixes #1536) - #1796
Open
Bhagyashri77777 wants to merge 15 commits into
Open
Bhagyashri77777 wants to merge 15 commits into
Bhagyashri77777 wants to merge 15 commits into
Conversation
Contributor
Author
|
Hi @imDarshanGK! I have updated the code to address the test configuration leakage, fixed the TTL logic, and resolved all the strict CI formatting and linting errors. All checks are finally passing green... Could you please re-review this when you have a moment? Thank you so much for your patience and for helping me learn... |
|
👋 This PR has had no activity for 7 days. Please push updates or comment if you still need more time. Inactive PRs may be closed automatically after 7 more days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #1536 by refactoring the repetitive logic inside the
AppCacheservice.Changes Made:
_get_valid_key()to safely handle thecache_enabledcheck and key generation.get()andset()methods to use this new helper function.This is contributed under GSSoC '26. Let me know if any other changes are needed!