{{ message }}
Move the sanitizer to purely be a filter.#110
Merged
Conversation
Closed
gsnedders
force-pushed
the
sanitizer-fixes-72
branch
from
0fd13c6 to
80a1425
Compare
gsnedders
force-pushed
the
sanitizer-fixes-72
branch
from
80a1425 to
28bf43b
Compare
gsnedders
force-pushed
the
sanitizer-fixes-72
branch
from
28bf43b to
28fb733
Compare
|
|
Member
Author
|
I think when squashed this is now ready to land. |
|
|
As we no longer need the sanitizer to be shared between a filter and a tokenizer, move the entire sanitizer to the filter module.
This is imported into this repo as its expectations are very much implementation dependent, with expectations amended to match our actual behaviour.
gsnedders
force-pushed
the
sanitizer-fixes-72
branch
from
f582c58 to
57dfcae
Compare
|
|
There was a problem hiding this comment.
It looks like this regex is trying to remove:
` Literal backtic...
\x00-\x20 Ascii table characters starting at NULL up to and including Space -- Mostly non-printable characters...
\x7f-\xa0 Bytes with values 127 (DELETE) -> 160. More non-printable characters...
\s Whitespace
I don't know why it would be doing these things ...
Member
Author
There was a problem hiding this comment.
My assumption is it's something to do with legacy attribute parsing in old UAs, for whom such characters can alter parsing.
gsnedders
added a commit
to gsnedders/html5lib-python
that referenced
this pull request
May 22, 2016
This should be unneeded since the sanitizer changes (html5lib#110)
gsnedders
added a commit
to gsnedders/html5lib-python
that referenced
this pull request
Jul 6, 2016
This should be unneeded since the sanitizer changes (html5lib#110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops support for the tokenizing side of thing, which is sadly the only side that works in previous releases. Fixes #72. See all discussion there.