Use python sets by blag · Pull Request #158 · html5lib/html5lib-python · GitHub
Skip to content

Use python sets#158

Closed
blag wants to merge 1 commit into
html5lib:masterfrom
blag:use_python_sets
Closed

Use python sets#158
blag wants to merge 1 commit into
html5lib:masterfrom
blag:use_python_sets

Conversation

@blag

@blag blag commented May 22, 2014

Copy link
Copy Markdown

Instead of

for (loop):
    if (condition):
        continue

simply use Python sets:

for attr in set(attrs.keys()).intersection(set(self.attr_val_is_uri)):
    ...

@hoppipolla-critic-bot

hoppipolla-critic-bot commented May 22, 2014

Copy link
Copy Markdown

@gsnedders

gsnedders commented May 29, 2014

Copy link
Copy Markdown
Member

Can you have each branch based on upstream master, so you don't have massive overlap between PRs? Note that #110 makes large changes to the sanitizer — including changing the lists to sets.

@blag

blag commented May 29, 2014

Copy link
Copy Markdown
Author

Sorry I'm still new to using Github's pull requests. This is fixed.

And yes, this is superseded by #110.

@gsnedders

gsnedders commented Jul 21, 2014

Copy link
Copy Markdown
Member

@gsnedders gsnedders closed this Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blag @hoppipolla-critic-bot @gsnedders