Change test methods visibility by friederbluemle · Pull Request #569 · googlemaps/android-maps-utils · GitHub
Skip to content

Change test methods visibility#569

Merged
jpoehnelt merged 1 commit into
googlemaps:masterfrom
friederbluemle:test-visibility
Oct 31, 2019
Merged

Change test methods visibility#569
jpoehnelt merged 1 commit into
googlemaps:masterfrom
friederbluemle:test-visibility

Conversation

@friederbluemle

@friederbluemle friederbluemle commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

These are the remaining changes from #556 by @ming13 rebased onto the latest master.

Once approved, please use a normal GitHub merge (i.e. NO rebase/squash merge) to integrate the commit(s) from the PR head branch. The changes are broken up into meaningful, atomic commits, and my branch should already be up-to-date with the latest base branch. If it isn't, or if you want me to change anything, please let me know, and I will update the branch as soon as possible. Thank you!

@googlebot

Copy link
Copy Markdown

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 29, 2019
@jpoehnelt

Copy link
Copy Markdown

@ming13 Mind commenting with @googlebot I consent. See #569 (comment).

@arturdryomov

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 31, 2019
@jpoehnelt jpoehnelt merged commit 75fed76 into googlemaps:master Oct 31, 2019
@friederbluemle friederbluemle deleted the test-visibility branch October 31, 2019 16:53
@friederbluemle

Copy link
Copy Markdown
Contributor Author

@jpoehnelt Thanks for merging! Just FYI (not sure if you're aware of it): By using a GitHub squash merge, the commit was rewritten on the GitHub server (changing author/committer information, and removing my GPG signature) - In addition, I had to force delete my local branch (since Git does not see the branch as fully merged). That's why I put that little small print note in the PR description ;) With the new commit that was added to the master branch, there is now no evidence that it was originally authored by @ming13
Not a big deal, but maybe next time you can use a regular merge (for branches that are fully rebased, and don't contain "fixup" commits). Thanks!

@jpoehnelt

Copy link
Copy Markdown

pauminku added a commit to pauminku/android-maps-utils that referenced this pull request Nov 26, 2019
* googleOrigin/master: (107 commits)
  Remove unnecessary interface method public modifiers. (googlemaps#587)
  Remove unnecessary primitives boxing. (googlemaps#586)
  Fix googlemaps#575 - Change Travis config, use matrix of API emulators (googlemaps#585)
  Retain the bitmap cache (googlemaps#381)
  Made GeoJsonParser with parseGeometry public to use the parser standalone. (googlemaps#492)
  Fix googlemaps#570 - Use project GitHub URL for remote KML loading demo (googlemaps#581)
  Bump Gradle plugin for Android Studio v3.5.2 (googlemaps#574)
  Fix googlemaps#575 - Use API 26 emulator instead of API 28 (googlemaps#576)
  Fix googlemaps#371 - Run emulator-based unit tests on Travis (googlemaps#573)
  Fix googlemaps#371 - Run emulator-based unit tests on Travis (googlemaps#573)
  Fix googlemaps#532 - Use ContextCompat to load drawable resources for scaling (googlemaps#571)
  Change test methods visibility (googlemaps#569)
  Release 0.6.2 (googlemaps#568)
  Demo clustering with ViewModel (googlemaps#506)
  Differentiate between initial start and configuration change restore (googlemaps#567)
  Fix wrapping around IDL (googlemaps#564)
  Update Gradle wrapper to 5.6.3 (googlemaps#566)
  Add MaxIntensity functionality for user defined intensities on HeatMapTiles (googlemaps#499)
  Use float zoom to calculate visible bounds (googlemaps#483)
  Remove apklib publishing (googlemaps#563)
  ...

# Conflicts:
#	library/src/androidTest/java/com/google/maps/android/PolyUtilTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants