Handle wrapping around international date line by jeffdgr8 · Pull Request #564 · googlemaps/android-maps-utils · GitHub
Skip to content

Handle wrapping around international date line#564

Merged
jpoehnelt merged 2 commits into
googlemaps:masterfrom
jeffdgr8:fix-cross-date-line
Oct 21, 2019
Merged

Handle wrapping around international date line#564
jpoehnelt merged 2 commits into
googlemaps:masterfrom
jeffdgr8:fix-cross-date-line

Conversation

@jeffdgr8

Copy link
Copy Markdown
Contributor

Fix displaying markers on both sides of the International Date Line in NonHierarchicalViewBasedAlgorithm.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2019
@jpoehnelt jpoehnelt added the triage me I really want to be triaged. label Oct 14, 2019
@jpoehnelt jpoehnelt self-requested a review October 15, 2019 17:52

@jpoehnelt jpoehnelt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response here, I'm not familiar with this code and the world width of 1 for mercator threw me off.

Shouldn't this follow a modulo solution?

I'm not setup to manually test right now. A unit test would be great 😄

@jpoehnelt jpoehnelt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a rebase

@jeffdgr8

Copy link
Copy Markdown
Contributor Author

@jpoehnelt jpoehnelt merged commit c1158e8 into googlemaps:master Oct 21, 2019
@jeffdgr8 jeffdgr8 deleted the fix-cross-date-line branch October 29, 2019 22:44
pauminku added a commit to pauminku/android-maps-utils that referenced this pull request Nov 26, 2019
* googleOrigin/master: (107 commits)
  Remove unnecessary interface method public modifiers. (googlemaps#587)
  Remove unnecessary primitives boxing. (googlemaps#586)
  Fix googlemaps#575 - Change Travis config, use matrix of API emulators (googlemaps#585)
  Retain the bitmap cache (googlemaps#381)
  Made GeoJsonParser with parseGeometry public to use the parser standalone. (googlemaps#492)
  Fix googlemaps#570 - Use project GitHub URL for remote KML loading demo (googlemaps#581)
  Bump Gradle plugin for Android Studio v3.5.2 (googlemaps#574)
  Fix googlemaps#575 - Use API 26 emulator instead of API 28 (googlemaps#576)
  Fix googlemaps#371 - Run emulator-based unit tests on Travis (googlemaps#573)
  Fix googlemaps#371 - Run emulator-based unit tests on Travis (googlemaps#573)
  Fix googlemaps#532 - Use ContextCompat to load drawable resources for scaling (googlemaps#571)
  Change test methods visibility (googlemaps#569)
  Release 0.6.2 (googlemaps#568)
  Demo clustering with ViewModel (googlemaps#506)
  Differentiate between initial start and configuration change restore (googlemaps#567)
  Fix wrapping around IDL (googlemaps#564)
  Update Gradle wrapper to 5.6.3 (googlemaps#566)
  Add MaxIntensity functionality for user defined intensities on HeatMapTiles (googlemaps#499)
  Use float zoom to calculate visible bounds (googlemaps#483)
  Remove apklib publishing (googlemaps#563)
  ...

# Conflicts:
#	library/src/androidTest/java/com/google/maps/android/PolyUtilTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. triage me I really want to be triaged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants