iframe-proxy

blakeli0 · 2026-03-10T03:13:06Z

This PR adds more attributes to metrics by introducing a getMetricsAttributes() in ApiTracerContext. It does not only add all known attributes, but also adds three new attributes to ApiTracerContext: serviceName(), urlDomain() and urlTemplate(). These three attributes are always empty for now and will be populated in future PRs.

…tricsTracer

…logics.

gemini-code-assist · 2026-03-10T03:13:27Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the observability framework by expanding the set of attributes collected for metrics. It introduces new fields in LibraryMetadata and ApiTracerContext to capture more detailed information such as library version, service name, and URL details. These additions enable a more granular and insightful analysis of client requests and their operational context, improving the overall diagnostic capabilities.

Highlights

Library Metadata Enhancement: Added a version attribute to LibraryMetadata to allow for capturing and associating library version information with metrics.
Extended API Tracer Context: Introduced serviceName, urlDomain, and urlTemplate attributes to ApiTracerContext, providing richer contextual data for tracing and metrics.
Metrics Attribute Aggregation: Implemented a new getMetricsAttributes() method in ApiTracerContext to consolidate and prepare these new attributes for metric recording.
Golden Signal Metrics Integration: Updated GoldenSignalMetricsTracer to accept ApiTracerContext in its constructor and to incorporate the additional attributes into the recorded golden signal metrics.
Tracer Factory Update: Modified GoldenSignalMetricsTracerFactory to correctly pass the ApiTracerContext when instantiating GoldenSignalMetricsTracer.

Changelog

gax-java/gax/src/main/java/com/google/api/gax/rpc/LibraryMetadata.java
- Added an abstract version() method to retrieve the library version.
- Added an abstract setVersion() method to the Builder for setting the library version.
gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracerContext.java
- Added an import for org.apache.http.protocol.HTTP.
- Included commented-out attribute names as a reference for future attribute additions.
- Added abstract methods for serviceName(), urlDomain(), and urlTemplate() to expose new tracing context attributes.
- Introduced a new getMetricsAttributes() method to compile a map of attributes relevant for metrics.
gax-java/gax/src/main/java/com/google/api/gax/tracing/GoldenSignalMetricsTracer.java
- Added a private final field apiTracerContext to store the tracing context.
- Modified the constructor to accept ApiTracerContext as a parameter.
- Updated operationSucceeded(), operationCancelled(), and operationFailed() methods to include attributes from apiTracerContext.getMetricsAttributes() in the recorded metrics.
gax-java/gax/src/main/java/com/google/api/gax/tracing/GoldenSignalMetricsTracerFactory.java
- Modified the newTracer() method to pass the apiTracerContext to the GoldenSignalMetricsTracer constructor.
gax-java/gax/src/test/java/com/google/api/gax/tracing/GoldenSignalMetricsTracerTest.java
- Updated the setUp() method to pass ApiTracerContext.empty() to the GoldenSignalMetricsTracer constructor for testing purposes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request enhances observability by introducing new attributes to metrics. However, it introduces a potential Denial of Service (DoS) vulnerability in the metrics recording logic due to incorrect variable usage and missing null checks, which can lead to application crashes. Specifically, the transport() method in ApiTracerContext is undefined, there are logical errors in how url.domain and url.template attributes are populated, and the gcp.client.version attribute is missing. Additionally, Javadoc is missing for a new constructor parameter, and new tests are required to cover the newly added metric attributes.

…or metrics.

sonarqubecloud · 2026-03-14T03:14:43Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-03-14T03:18:39Z

🤖 I have created a release *beep* *boop* --- <details><summary>2.68.0</summary> ## [2.68.0](v2.67.0...v2.68.0) (2026-03-17) ### Features * Add client request duration metric. ([#4132](#4132)) ([6a76397](6a76397)) * Add more attributes to golden signals metrics. ([#4135](#4135)) ([59d0624](59d0624)) * **gax-httpjson:** add HttpJsonErrorParser utility ([#4137](#4137)) ([a1b7565](a1b7565)) * **generator:** add extra allowed modules that will not be removed from the monorepo if they are present ([#4124](#4124)) ([774fe6e](774fe6e)) * **o11y:** introduce `gcp.client.repo` and `gcp.client.artifact` attributes ([#4120](#4120)) ([105f644](105f644)) * **o11y:** Introduce `rpc.system.name` and `rpc.method` in gRPC ([#4121](#4121)) ([7ab6d2e](7ab6d2e)) * **o11y:** introduce server.port attribute ([#4128](#4128)) ([56aa343](56aa343)) ### Bug Fixes * add null checks for ApiTracerFactory in ClientContext ([#4122](#4122)) ([4b3dbe2](4b3dbe2)) * Decrease log level for directpath warnings outside GCE ([#4139](#4139)) ([c9651e7](c9651e7)) * **gax-grpc:** add pick_first fallback to direct path service config ([#4143](#4143)) ([b150fe9](b150fe9)) * Populate method level attributes in metrics recording ([#4149](#4149)) ([7b7e6c9](7b7e6c9)) * suppress warnings in generated projects for non-idiomatic durations ([#4119](#4119)) ([4206e6e](4206e6e)) * Use ServiceName + MethodName as the regex for Otel ([#2543](#2543)) ([b9ae73f](b9ae73f)) ### Documentation * **hermetic_build:** fix config field name in readme ([#4130](#4130)) ([a0c8f67](a0c8f67)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>2.68.0</summary> ## [2.68.0](googleapis/sdk-platform-java@v2.67.0...v2.68.0) (2026-03-17) ### Features * Add client request duration metric. ([#4132](googleapis/sdk-platform-java#4132)) ([487650e](googleapis/sdk-platform-java@487650e)) * Add more attributes to golden signals metrics. ([#4135](googleapis/sdk-platform-java#4135)) ([bc82dcb](googleapis/sdk-platform-java@bc82dcb)) * **gax-httpjson:** add HttpJsonErrorParser utility ([#4137](googleapis/sdk-platform-java#4137)) ([6fe2446](googleapis/sdk-platform-java@6fe2446)) * **generator:** add extra allowed modules that will not be removed from the monorepo if they are present ([#4124](googleapis/sdk-platform-java#4124)) ([6a440da](googleapis/sdk-platform-java@6a440da)) * **o11y:** introduce `gcp.client.repo` and `gcp.client.artifact` attributes ([#4120](googleapis/sdk-platform-java#4120)) ([4954de5](googleapis/sdk-platform-java@4954de5)) * **o11y:** Introduce `rpc.system.name` and `rpc.method` in gRPC ([#4121](googleapis/sdk-platform-java#4121)) ([3593c30](googleapis/sdk-platform-java@3593c30)) * **o11y:** introduce server.port attribute ([#4128](googleapis/sdk-platform-java#4128)) ([1b10e02](googleapis/sdk-platform-java@1b10e02)) ### Bug Fixes * add null checks for ApiTracerFactory in ClientContext ([#4122](googleapis/sdk-platform-java#4122)) ([ded1922](googleapis/sdk-platform-java@ded1922)) * Decrease log level for directpath warnings outside GCE ([#4139](googleapis/sdk-platform-java#4139)) ([5151f34](googleapis/sdk-platform-java@5151f34)) * **gax-grpc:** add pick_first fallback to direct path service config ([#4143](googleapis/sdk-platform-java#4143)) ([4934ad8](googleapis/sdk-platform-java@4934ad8)) * Populate method level attributes in metrics recording ([#4149](googleapis/sdk-platform-java#4149)) ([69aabf8](googleapis/sdk-platform-java@69aabf8)) * suppress warnings in generated projects for non-idiomatic durations ([#4119](googleapis/sdk-platform-java#4119)) ([8a0c565](googleapis/sdk-platform-java@8a0c565)) * Use ServiceName + MethodName as the regex for Otel ([#2543](googleapis/sdk-platform-java#2543)) ([8196b8f](googleapis/sdk-platform-java@8196b8f)) ### Documentation * **hermetic_build:** fix config field name in readme ([#4130](googleapis/sdk-platform-java#4130)) ([0d98c37](googleapis/sdk-platform-java@0d98c37)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

blakeli0 added 9 commits March 6, 2026 23:39

feat: Add basic golden telemetry metrics.

2bffab2

fix: Add error message for IllegalStateException in GoldenTelemetryMe…

cb368ab

…tricsTracer

fix: Add opentelemetry_sdk_testing to dependencies.properties

d17ebd9

fix: Rename to GoldenSignal

2ba106a

feat: Add GoldenSignalsMetricsRecorder to wrap OpenTelemetry related …

2bbfda3

…logics.

fix: Remove VisibleForTesting annotation.

6123e58

fix: Remove unused fields in tests

58951af

test: Update unit tests.

3bd6f0a

feat: Add more attributes to metrics.

59f320c

product-auto-label Bot added the size: m Pull request size is medium. label Mar 10, 2026

gemini-code-assist Bot reviewed Mar 10, 2026

View reviewed changes

Base automatically changed from add-basic-metrics to main March 11, 2026 21:35

blakeli0 added 2 commits March 13, 2026 16:43

Merge branch 'main' into add-metrics-attributes

ef59e3e

fix: Add more attributes. Refactor attributes from String to Object f…

c0622b5

…or metrics.

product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 14, 2026

blakeli0 marked this pull request as ready for review March 14, 2026 02:52

Merge branch 'main' into add-metrics-attributes

9965f24

blakeli0 changed the title ~~feat: Add more attributes to metrics.~~ feat: Add more attributes to golden signals metrics. Mar 14, 2026

diegomarquezp approved these changes Mar 16, 2026

View reviewed changes

blakeli0 merged commit 59d0624 into main Mar 16, 2026
71 of 74 checks passed

blakeli0 deleted the add-metrics-attributes branch March 16, 2026 16:43

release-please Bot mentioned this pull request Mar 16, 2026

chore(main): release 2.68.0 #4123

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add more attributes to golden signals metrics.#4135

feat: Add more attributes to golden signals metrics.#4135
blakeli0 merged 12 commits into
mainfrom
add-metrics-attributes

blakeli0 commented Mar 10, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Mar 10, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 14, 2026

Uh oh!

sonarqubecloud Bot commented Mar 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

blakeli0 commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 10, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 14, 2026

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

sonarqubecloud Bot commented Mar 14, 2026

Quality Gate failed for 'java_showcase_integration_tests'

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

blakeli0 commented Mar 10, 2026 •

edited

Loading