iframe-proxy

igorbernstein2 · 2026-02-25T16:51:08Z

Removes compiler warnings like

 [CanonicalDuration] Duration can be expressed more clearly with different units
    (see https://errorprone.info/bugpattern/CanonicalDuration)
  Did you mean '.setMaxRetryDelayDuration(Duration.ofSeconds(45))'?

from generated clients

…ressed more clearly with different units"

gemini-code-assist · 2026-02-25T16:51:35Z

Summary of Changes

Hello @igorbernstein2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where generated client libraries were producing CanonicalDuration compiler warnings. By integrating a suppression annotation directly into the code generation process, it aims to provide cleaner build outputs for users of these generated clients, improving the overall developer experience without altering the functional behavior of the generated code. Additionally, a minor improvement was made to test assertion messages for better debugging.

Highlights

Warning Suppression: Implemented a mechanism to suppress CanonicalDuration compiler warnings in generated client code, specifically for StubSettings classes.
Code Generation Logic Update: Modified the AbstractServiceStubSettingsClassComposer to automatically add the @SuppressWarnings("CanonicalDuration") annotation to newly generated StubSettings classes.
Golden File Updates: Updated multiple golden test files to reflect the addition of the @SuppressWarnings("CanonicalDuration") annotation, ensuring consistency with the new generation logic.
Improved Test Assertion: Enhanced the Assert.assertCodeEquals method to include the golden file path in assertion failure messages, making debugging easier.

Changelog

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java
- Added logic to apply the @SuppressWarnings("CanonicalDuration") annotation to generated StubSettings classes.
- Included SuppressWarnings.class in the static type store for proper annotation generation.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/ApiVersionTestingStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/DeprecatedServiceStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/EchoServiceSelectiveGapicStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/EchoStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/JobServiceStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/LoggingServiceV2StubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/PublisherStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpcrest/goldens/WickedStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/rest/goldens/ComplianceStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/rest/goldens/HttpJsonApiVersionTestingStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/grpcrest/goldens/EchoStubSettings.golden
- Applied @SuppressWarnings("CanonicalDuration") annotation to the generated class.
gapic-generator-java/src/test/java/com/google/api/generator/test/framework/Assert.java
- Modified the assertion error message to include the golden file path for better debugging.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

igorbernstein2 · 2026-02-25T16:51:45Z

/gcbrun

gemini-code-assist

Code Review

This pull request suppresses the CanonicalDuration warning from Error Prone in generated client code by adding @SuppressWarnings("CanonicalDuration") to the ...StubSettings classes. The implementation is correct and effectively achieves this goal. Additionally, an improvement to the test assertion messages has been included, which will be helpful for debugging. A minor suggestion to improve a comment for clarity has been noted.

…pic/composer/common/AbstractServiceStubSettingsClassComposer.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

blakeli0 · 2026-02-26T22:12:56Z

/gcbrun

blakeli0 · 2026-02-27T14:29:28Z

🤖 I have created a release *beep* *boop* --- <details><summary>2.68.0</summary> ## [2.68.0](v2.67.0...v2.68.0) (2026-03-17) ### Features * Add client request duration metric. ([#4132](#4132)) ([6a76397](6a76397)) * Add more attributes to golden signals metrics. ([#4135](#4135)) ([59d0624](59d0624)) * **gax-httpjson:** add HttpJsonErrorParser utility ([#4137](#4137)) ([a1b7565](a1b7565)) * **generator:** add extra allowed modules that will not be removed from the monorepo if they are present ([#4124](#4124)) ([774fe6e](774fe6e)) * **o11y:** introduce `gcp.client.repo` and `gcp.client.artifact` attributes ([#4120](#4120)) ([105f644](105f644)) * **o11y:** Introduce `rpc.system.name` and `rpc.method` in gRPC ([#4121](#4121)) ([7ab6d2e](7ab6d2e)) * **o11y:** introduce server.port attribute ([#4128](#4128)) ([56aa343](56aa343)) ### Bug Fixes * add null checks for ApiTracerFactory in ClientContext ([#4122](#4122)) ([4b3dbe2](4b3dbe2)) * Decrease log level for directpath warnings outside GCE ([#4139](#4139)) ([c9651e7](c9651e7)) * **gax-grpc:** add pick_first fallback to direct path service config ([#4143](#4143)) ([b150fe9](b150fe9)) * Populate method level attributes in metrics recording ([#4149](#4149)) ([7b7e6c9](7b7e6c9)) * suppress warnings in generated projects for non-idiomatic durations ([#4119](#4119)) ([4206e6e](4206e6e)) * Use ServiceName + MethodName as the regex for Otel ([#2543](#2543)) ([b9ae73f](b9ae73f)) ### Documentation * **hermetic_build:** fix config field name in readme ([#4130](#4130)) ([a0c8f67](a0c8f67)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>2.68.0</summary> ## [2.68.0](googleapis/sdk-platform-java@v2.67.0...v2.68.0) (2026-03-17) ### Features * Add client request duration metric. ([#4132](googleapis/sdk-platform-java#4132)) ([487650e](googleapis/sdk-platform-java@487650e)) * Add more attributes to golden signals metrics. ([#4135](googleapis/sdk-platform-java#4135)) ([bc82dcb](googleapis/sdk-platform-java@bc82dcb)) * **gax-httpjson:** add HttpJsonErrorParser utility ([#4137](googleapis/sdk-platform-java#4137)) ([6fe2446](googleapis/sdk-platform-java@6fe2446)) * **generator:** add extra allowed modules that will not be removed from the monorepo if they are present ([#4124](googleapis/sdk-platform-java#4124)) ([6a440da](googleapis/sdk-platform-java@6a440da)) * **o11y:** introduce `gcp.client.repo` and `gcp.client.artifact` attributes ([#4120](googleapis/sdk-platform-java#4120)) ([4954de5](googleapis/sdk-platform-java@4954de5)) * **o11y:** Introduce `rpc.system.name` and `rpc.method` in gRPC ([#4121](googleapis/sdk-platform-java#4121)) ([3593c30](googleapis/sdk-platform-java@3593c30)) * **o11y:** introduce server.port attribute ([#4128](googleapis/sdk-platform-java#4128)) ([1b10e02](googleapis/sdk-platform-java@1b10e02)) ### Bug Fixes * add null checks for ApiTracerFactory in ClientContext ([#4122](googleapis/sdk-platform-java#4122)) ([ded1922](googleapis/sdk-platform-java@ded1922)) * Decrease log level for directpath warnings outside GCE ([#4139](googleapis/sdk-platform-java#4139)) ([5151f34](googleapis/sdk-platform-java@5151f34)) * **gax-grpc:** add pick_first fallback to direct path service config ([#4143](googleapis/sdk-platform-java#4143)) ([4934ad8](googleapis/sdk-platform-java@4934ad8)) * Populate method level attributes in metrics recording ([#4149](googleapis/sdk-platform-java#4149)) ([69aabf8](googleapis/sdk-platform-java@69aabf8)) * suppress warnings in generated projects for non-idiomatic durations ([#4119](googleapis/sdk-platform-java#4119)) ([8a0c565](googleapis/sdk-platform-java@8a0c565)) * Use ServiceName + MethodName as the regex for Otel ([#2543](googleapis/sdk-platform-java#2543)) ([8196b8f](googleapis/sdk-platform-java@8196b8f)) ### Documentation * **hermetic_build:** fix config field name in readme ([#4130](googleapis/sdk-platform-java#4130)) ([0d98c37](googleapis/sdk-platform-java@0d98c37)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

igorbernstein2 added 2 commits February 25, 2026 11:25

fix: suppress warnings in generated projects for "Duration can be exp…

8969295

…ressed more clearly with different units"

fix tests

3fc2751

product-auto-label Bot added the size: s Pull request size is small. label Feb 25, 2026

gemini-code-assist Bot reviewed Feb 25, 2026

View reviewed changes

Comment thread ...com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java Outdated

igorbernstein2 and others added 4 commits February 26, 2026 14:17

update integration tests

5366dfc

format

a25f72d

Update gapic-generator-java/src/main/java/com/google/api/generator/ga…

b0cd3a6

…pic/composer/common/AbstractServiceStubSettingsClassComposer.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

update showcase

eaa6422

Merge branch 'main' into suppress-warning

4c37c53

blakeli0 approved these changes Feb 27, 2026

View reviewed changes

blakeli0 merged commit 4206e6e into googleapis:main Feb 27, 2026
48 of 51 checks passed

release-please Bot mentioned this pull request Feb 27, 2026

chore(main): release 2.68.0 #4123

Merged

diegomarquezp mentioned this pull request Mar 13, 2026

chore(observability/tracing-attr/gcp.client.version-2): release 2.68.0 #4141

Closed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: suppress warnings in generated projects for non-idiomatic durations#4119

fix: suppress warnings in generated projects for non-idiomatic durations#4119
blakeli0 merged 7 commits into
googleapis:mainfrom
igorbernstein2:suppress-warning

igorbernstein2 commented Feb 25, 2026

Uh oh!

gemini-code-assist Bot commented Feb 25, 2026

Uh oh!

igorbernstein2 commented Feb 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

blakeli0 commented Feb 26, 2026

Uh oh!

blakeli0 commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

igorbernstein2 commented Feb 25, 2026

Uh oh!

gemini-code-assist Bot commented Feb 25, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

igorbernstein2 commented Feb 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

blakeli0 commented Feb 26, 2026

Uh oh!

blakeli0 commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants