iframe-proxy

daniel-sanche · 2026-03-07T00:42:53Z

only google.auth.transport.requests.Request objects have a session attached. Other Request subclasses don't so they raise an error when mts is enabled.

This PR ignores unsupported request types, instead of raising an exception

Thanks @sakshamgoyal-01 for the detailed bug report!

gemini-code-assist · 2026-03-07T00:43:07Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug where the authentication process would fail if a request object did not possess a 'session' attribute, leading to an AttributeError. The change enhances the robustness of the system by adding a preliminary check for the attribute's existence, ensuring that mTLS setup proceeds smoothly without unexpected exceptions. This improves the overall stability and reliability of authentication flows.

Highlights

Bug Fix: Addressed an AttributeError that occurred when a request object lacked a session attribute during mTLS setup, preventing crashes in authentication processes.
Robustness: Implemented a check using hasattr() to safely determine if the session attribute exists on the request object before attempting to access it.
Testing: Introduced a new regression test case to specifically validate the fix for the AttributeError scenario, ensuring the issue does not reoccur.

Changelog

packages/google-auth/google/auth/compute_engine/_metadata.py
- Modified the _prepare_request_for_mds function to include a hasattr check for the session attribute on the request object before attempting to access it, preventing an AttributeError.
packages/google-auth/tests/compute_engine/test__metadata.py
- Added a new test case, test__prepare_request_for_mds_mtls_attribute_error, to specifically test the scenario where a request object initially lacks a session attribute, ensuring the fix works as expected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly fixes an AttributeError that occurred when a request object was missing the session attribute. The fix involves adding a check for the attribute's existence before use, and a new regression test has been added to cover this case. I have one suggestion to make the code slightly more concise and Pythonic.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

daniel-sanche · 2026-03-10T00:05:42Z

/gemini review

gemini-code-assist

Code Review

This pull request addresses an AttributeError that occurs when mTLS is enabled with request objects lacking a session attribute. The fix involves adding a check for the session attribute before use, and a new regression test is included to verify this. No security vulnerabilities were found. My feedback focuses on enhancing the robustness of this check by using isinstance instead of hasattr, which will prevent potential runtime errors if a session attribute exists but is not of the expected type.

gemini-code-assist · 2026-03-10T00:07:25Z

+    if use_mtls and hasattr(request, "session"):
        # Ensure the request has a session to mount the adapter to.
        if not request.session:
            request.session = requests.Session()


Using hasattr(request, "session") is a good first step, but it's not entirely safe. It's possible for a different Request implementation to have a session attribute that isn't a requests.Session object. This could lead to an AttributeError later when request.session.mount is called.

A more robust approach is to explicitly check if request is an instance of google.auth.transport.requests.Request. This ensures you're working with the correct object type and avoids potential issues with incompatible session attributes.

Suggested change

if use_mtls and hasattr(request, "session"):

# Ensure the request has a session to mount the adapter to.

if not request.session:

request.session = requests.Session()

if use_mtls:

# Only modify the request if it's a requests-based transport.

from google.auth.transport import requests as auth_requests

if isinstance(request, auth_requests.Request):

# Ensure the request has a session to mount the adapter to.

if not request.session:

request.session = requests.Session()

sai-sunder-s · 2026-03-10T17:32:31Z

+    # Only modify the request if mTLS is enabled, and request supports sessions.
+    if use_mtls and hasattr(request, "session"):
        # Ensure the request has a session to mount the adapter to.
        if not request.session:


Is this condition required anymore? Since we already check that session is present?

Yes, I believe this is meant to attach a session if it's set to None

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.0.0-20260216162532-e323d455c92b Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c <details><summary>google-ads-datamanager: v0.6.0</summary> ## [v0.6.0](google-ads-datamanager-v0.5.0...google-ads-datamanager-v0.6.0) (2026-03-12) ### Documentation * update filter field documentation to clarify case requirements and improve examples ([505bc97](505bc97)) ### Features * deprecate INVALID_COUNTRY_CODE and add MEMBERSHIP_DURATION_TOO_LONG to the ErrorReason enum ([505bc97](505bc97)) ### Bug Fixes * feat: update advertiser_identifier_count in PairIdInfo to be optional ([505bc97](505bc97)) * update publisher_name in PairIdInfo to be required ([505bc97](505bc97)) * update match_rate_percentage in PairIdInfo to be required ([505bc97](505bc97)) </details> <details><summary>google-auth: v2.49.1</summary> ## [v2.49.1](google-auth-v2.49.0...google-auth-v2.49.1) (2026-03-12) ### Bug Fixes * fix request session error (#16050) ([bfd9322](bfd93225)) * remove deprecated rsa dependency (#16020) ([e8927b9](e8927b9c)) </details> <details><summary>google-cloud-ces: v0.2.0</summary> ## [v0.2.0](google-cloud-ces-v0.1.0...google-cloud-ces-v0.2.0) (2026-03-12) ### Documentation * A comment for field `cert` in message `.google.cloud.ces.v1beta.TlsConfig` is changed ([505bc97](505bc97)) * A comment for field `name` in message `.google.cloud.ces.v1beta.Tool` is changed PiperOrigin-RevId: 878047537 ([505bc97](505bc97)) * A comment for field `entry_agent` in message `.google.cloud.ces.v1beta.SessionConfig` is changed ([505bc97](505bc97)) ### Features * update public libraries for CES v1beta ([505bc97](505bc97)) ### Bug Fixes * An existing field `app` is renamed to `name` in message `.google.cloud.ces.v1beta.UploadEvaluationAudioRequest` ([505bc97](505bc97)) * An existing field `audio_transcript` is renamed to `transcript` in message `.google.cloud.ces.v1beta.UploadEvaluationAudioResponse` ([505bc97](505bc97)) * An existing field `audio_duration` is renamed to `duration` in message `.google.cloud.ces.v1beta.UploadEvaluationAudioResponse` ([505bc97](505bc97)) * An existing field `variables` is moved in to oneof in message `.google.cloud.ces.v1beta.ExecuteToolRequest` ([505bc97](505bc97)) * An existing method_signature `app,audio_content` is removed from method `UploadEvaluationAudio` in service `EvaluationService` ([505bc97](505bc97)) * An existing google.api.http annotation `http_uri` is changed for method `UploadEvaluationAudio` in service `EvaluationService` ([505bc97](505bc97)) </details> <details><summary>google-cloud-compute: v1.46.0</summary> ## [1.46.0](google-cloud-compute-v1.45.0...google-cloud-compute-v1.46.0) (2026-03-12) ### Features * Update Compute Engine v1 API to revision 20260227 ([7b22ea2](7b22ea2)) </details> <details><summary>google-cloud-compute-v1beta: v0.9.0</summary> ## [0.9.0](google-cloud-compute-v1beta-v0.8.0...google-cloud-compute-v1beta-v0.9.0) (2026-03-12) ### Features * Update Compute Engine v1beta API to revision 20260227 ([bf43768](bf43768)) </details> <details><summary>google-cloud-firestore: v2.25.0</summary> ## [v2.25.0](google-cloud-firestore-v2.24.0...google-cloud-firestore-v2.25.0) (2026-03-12) ### Features * support array_agg(), array_agg_distinct(), first(), last() (#16029) ([d04a241](d04a241d)) </details> <details><summary>google-cloud-gdchardwaremanagement: v0.4.0</summary> ## [0.4.0](google-cloud-gdchardwaremanagement-v0.3.0...google-cloud-gdchardwaremanagement-v0.4.0) (2026-03-12) ### Features * Add `OFFLINE` state to Zone resources A new `OFFLINE` state has been added to the `Zone.State` enum. This state indicates that the zone is temporarily not operational, for example, while undergoing maintenance or repair ([505bc97](505bc97)) </details> <details><summary>google-cloud-geminidataanalytics: v0.11.0</summary> ## [0.11.0](google-cloud-geminidataanalytics-v0.10.0...google-cloud-geminidataanalytics-v0.11.0) (2026-03-12) ### Documentation * update field comments for `generated_looker_query` in `DataMessage` ([505bc97](505bc97)) ### Features * add `ParameterizedSecureViewParameters` message and field for PSV support ([505bc97](505bc97)) * add `ThinkingMode` enum and field to control agent thinking mode ([505bc97](505bc97)) </details> <details><summary>google-cloud-gke-hub: v1.22.0</summary> ## [1.22.0](google-cloud-gke-hub-v1.21.0...google-cloud-gke-hub-v1.22.0) (2026-03-12) ### Features * upgrade protobuf from v25.7 to v31.0 ([505bc97](505bc97)) </details> <details><summary>google-cloud-pubsub: v2.36.0</summary> ## [2.36.0](google-cloud-pubsub-v2.35.0...google-cloud-pubsub-v2.36.0) (2026-03-12) ### Features * Add BigtableConfig type ([ec1a676](ec1a676)) </details> <details><summary>google-maps-routing: v0.9.0</summary> ## [0.9.0](google-maps-routing-v0.8.0...google-maps-routing-v0.9.0) (2026-03-12) ### Documentation * regenerated documentation for fields ([505bc97](505bc97)) ### Features * add a new Waypoint source to accept a token that identifies a Navigation Point obtained from the `SearchDestinations` method of the Geocoding API ([505bc97](505bc97)) </details> <details><summary>google-resumable-media: v2.8.1</summary> ## [v2.8.1](google-resumable-media-v2.8.0...google-resumable-media-v2.8.1) (2026-03-12) ### Bug Fixes * add max_length support to Gzip/Brotli decoders for urllib3 2.6+ (#495) ([cb90060](cb900605)) </details> <details><summary>google-shopping-type: v1.3.0</summary> ## [1.3.0](google-shopping-type-v1.2.0...google-shopping-type-v1.3.0) (2026-03-12) ### Documentation * A comment for message `DestintionEnum` is changed ([505bc97](505bc97)) ### Features * add more values in DestintionEnum ([505bc97](505bc97)) </details> --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

daniel-sanche added 2 commits March 6, 2026 16:38

added reproductive test

300b417

added fix

0867d5d

daniel-sanche requested review from a team as code owners March 7, 2026 00:42

gemini-code-assist Bot reviewed Mar 7, 2026

View reviewed changes

Comment thread packages/google-auth/google/auth/compute_engine/_metadata.py Outdated

daniel-sanche and others added 2 commits March 6, 2026 16:46

fixed lint

99b3e2a

Update packages/google-auth/google/auth/compute_engine/_metadata.py

9a49f21

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

daniel-sanche commented Mar 7, 2026

View reviewed changes

Comment thread packages/google-auth/google/auth/compute_engine/_metadata.py

daniel-sanche added 2 commits March 6, 2026 17:18

updated docstring

af098fb

ignore http requests

0c28180

gemini-code-assist Bot reviewed Mar 10, 2026

View reviewed changes

sai-sunder-s reviewed Mar 10, 2026

View reviewed changes

sai-sunder-s approved these changes Mar 10, 2026

View reviewed changes

daniel-sanche mentioned this pull request Mar 11, 2026

fix google-auth: use auth.transport.requests as default #16076

Closed

parthea approved these changes Mar 12, 2026

View reviewed changes

daniel-sanche merged commit bfd9322 into main Mar 12, 2026
31 checks passed

daniel-sanche deleted the auth_fix_request_session branch March 12, 2026 00:09

cloud-sdk-librarian-robot mentioned this pull request Mar 12, 2026

chore: librarian release pull request: 20260312T071352Z #16087

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(auth): fix request session error #16050

fix(auth): fix request session error #16050
daniel-sanche merged 6 commits intomainfrom
auth_fix_request_session

daniel-sanche commented Mar 7, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Mar 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

daniel-sanche commented Mar 10, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 10, 2026

Uh oh!

sai-sunder-s Mar 10, 2026

Uh oh!

daniel-sanche Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

daniel-sanche commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 7, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

daniel-sanche commented Mar 10, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

sai-sunder-s Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-sanche Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daniel-sanche commented Mar 7, 2026 •

edited

Loading