iframe-proxy

daniel-sanche · 2026-03-03T23:37:56Z

Coping over googleapis/google-auth-library-python#1930 to the new repo

This PR removes rsa as a required dependency, now that it has been replaced with cryptography (with warnings issued)

This change has been released as the 2.49.0.dev0 pre-release

gemini-code-assist · 2026-03-03T23:38:18Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the google-auth library's RSA implementation to remove the rsa package as a mandatory dependency. By transitioning to cryptography as the primary RSA backend and making rsa an optional extra, the change reduces the core dependency footprint and improves flexibility for users who may not require the rsa library's specific key types. This ensures that the library remains functional for users relying on rsa.key objects while not forcing the dependency on all users.

Highlights

Dependency Management: The rsa library was removed as a direct, mandatory dependency from the core google-auth package, reducing the default installation footprint.
Optional Dependency: The rsa library is now an optional extra dependency, allowing users to install it explicitly via pip install google-auth[rsa] if they require its specific key types.
Dynamic Module Loading: The RSAVerifier and RSASigner classes were updated to dynamically import the _python_rsa module only when rsa.key objects are provided, ensuring it's loaded on demand rather than at module initialization.
Improved Error Handling: Docstrings for RSAVerifier and RSASigner were updated to explicitly mention a potential ImportError if the rsa library is not installed when attempting to use rsa.key objects.

Changelog

packages/google-auth/google/auth/crypt/rsa.py
- Removed the top-level import of _python_rsa.
- Introduced conditional, local imports of _python_rsa within the RSAVerifier and RSASigner constructors.
- Added ImportError to the docstrings of RSAVerifier and RSASigner to inform users about potential errors if rsa is not installed.
packages/google-auth/setup.py
- Removed rsa from the main DEPENDENCIES list.
- Defined rsa_extra_require to specify rsa as an optional dependency.
- Included rsa_extra_require in testing_extra_require to ensure test environments can still use it.
- Added rsa_extra_require to the extras dictionary, making it installable via pip install google-auth[rsa].
packages/google-auth/testing/constraints-3.8.txt
- Removed the rsa package from the pinned dependency list for Python 3.8.
packages/google-auth/tests/crypt/test_rsa.py
- Added a type: ignore comment to the import rsa as rsa_lib statement to suppress type checking warnings.

Activity

This change is a re-application of a previous pull request (fix: remove deprecated rsa dependency google-auth-library-python#1930) to the new repository structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly removes rsa as a required dependency and makes it an optional extra. The lazy-loading of _python_rsa in google/auth/crypt/rsa.py is implemented well. However, I've identified a critical issue in setup.py where the new rsa extra is incorrectly added to the testing requirements. This would break the test environment setup. My review comment provides a fix for this issue.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.0.0-20260216162532-e323d455c92b Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c <details><summary>google-ads-datamanager: v0.6.0</summary> ## [v0.6.0](google-ads-datamanager-v0.5.0...google-ads-datamanager-v0.6.0) (2026-03-12) ### Documentation * update filter field documentation to clarify case requirements and improve examples ([505bc97](505bc97)) ### Features * deprecate INVALID_COUNTRY_CODE and add MEMBERSHIP_DURATION_TOO_LONG to the ErrorReason enum ([505bc97](505bc97)) ### Bug Fixes * feat: update advertiser_identifier_count in PairIdInfo to be optional ([505bc97](505bc97)) * update publisher_name in PairIdInfo to be required ([505bc97](505bc97)) * update match_rate_percentage in PairIdInfo to be required ([505bc97](505bc97)) </details> <details><summary>google-auth: v2.49.1</summary> ## [v2.49.1](google-auth-v2.49.0...google-auth-v2.49.1) (2026-03-12) ### Bug Fixes * fix request session error (#16050) ([bfd9322](bfd93225)) * remove deprecated rsa dependency (#16020) ([e8927b9](e8927b9c)) </details> <details><summary>google-cloud-ces: v0.2.0</summary> ## [v0.2.0](google-cloud-ces-v0.1.0...google-cloud-ces-v0.2.0) (2026-03-12) ### Documentation * A comment for field `cert` in message `.google.cloud.ces.v1beta.TlsConfig` is changed ([505bc97](505bc97)) * A comment for field `name` in message `.google.cloud.ces.v1beta.Tool` is changed PiperOrigin-RevId: 878047537 ([505bc97](505bc97)) * A comment for field `entry_agent` in message `.google.cloud.ces.v1beta.SessionConfig` is changed ([505bc97](505bc97)) ### Features * update public libraries for CES v1beta ([505bc97](505bc97)) ### Bug Fixes * An existing field `app` is renamed to `name` in message `.google.cloud.ces.v1beta.UploadEvaluationAudioRequest` ([505bc97](505bc97)) * An existing field `audio_transcript` is renamed to `transcript` in message `.google.cloud.ces.v1beta.UploadEvaluationAudioResponse` ([505bc97](505bc97)) * An existing field `audio_duration` is renamed to `duration` in message `.google.cloud.ces.v1beta.UploadEvaluationAudioResponse` ([505bc97](505bc97)) * An existing field `variables` is moved in to oneof in message `.google.cloud.ces.v1beta.ExecuteToolRequest` ([505bc97](505bc97)) * An existing method_signature `app,audio_content` is removed from method `UploadEvaluationAudio` in service `EvaluationService` ([505bc97](505bc97)) * An existing google.api.http annotation `http_uri` is changed for method `UploadEvaluationAudio` in service `EvaluationService` ([505bc97](505bc97)) </details> <details><summary>google-cloud-compute: v1.46.0</summary> ## [1.46.0](google-cloud-compute-v1.45.0...google-cloud-compute-v1.46.0) (2026-03-12) ### Features * Update Compute Engine v1 API to revision 20260227 ([7b22ea2](7b22ea2)) </details> <details><summary>google-cloud-compute-v1beta: v0.9.0</summary> ## [0.9.0](google-cloud-compute-v1beta-v0.8.0...google-cloud-compute-v1beta-v0.9.0) (2026-03-12) ### Features * Update Compute Engine v1beta API to revision 20260227 ([bf43768](bf43768)) </details> <details><summary>google-cloud-firestore: v2.25.0</summary> ## [v2.25.0](google-cloud-firestore-v2.24.0...google-cloud-firestore-v2.25.0) (2026-03-12) ### Features * support array_agg(), array_agg_distinct(), first(), last() (#16029) ([d04a241](d04a241d)) </details> <details><summary>google-cloud-gdchardwaremanagement: v0.4.0</summary> ## [0.4.0](google-cloud-gdchardwaremanagement-v0.3.0...google-cloud-gdchardwaremanagement-v0.4.0) (2026-03-12) ### Features * Add `OFFLINE` state to Zone resources A new `OFFLINE` state has been added to the `Zone.State` enum. This state indicates that the zone is temporarily not operational, for example, while undergoing maintenance or repair ([505bc97](505bc97)) </details> <details><summary>google-cloud-geminidataanalytics: v0.11.0</summary> ## [0.11.0](google-cloud-geminidataanalytics-v0.10.0...google-cloud-geminidataanalytics-v0.11.0) (2026-03-12) ### Documentation * update field comments for `generated_looker_query` in `DataMessage` ([505bc97](505bc97)) ### Features * add `ParameterizedSecureViewParameters` message and field for PSV support ([505bc97](505bc97)) * add `ThinkingMode` enum and field to control agent thinking mode ([505bc97](505bc97)) </details> <details><summary>google-cloud-gke-hub: v1.22.0</summary> ## [1.22.0](google-cloud-gke-hub-v1.21.0...google-cloud-gke-hub-v1.22.0) (2026-03-12) ### Features * upgrade protobuf from v25.7 to v31.0 ([505bc97](505bc97)) </details> <details><summary>google-cloud-pubsub: v2.36.0</summary> ## [2.36.0](google-cloud-pubsub-v2.35.0...google-cloud-pubsub-v2.36.0) (2026-03-12) ### Features * Add BigtableConfig type ([ec1a676](ec1a676)) </details> <details><summary>google-maps-routing: v0.9.0</summary> ## [0.9.0](google-maps-routing-v0.8.0...google-maps-routing-v0.9.0) (2026-03-12) ### Documentation * regenerated documentation for fields ([505bc97](505bc97)) ### Features * add a new Waypoint source to accept a token that identifies a Navigation Point obtained from the `SearchDestinations` method of the Geocoding API ([505bc97](505bc97)) </details> <details><summary>google-resumable-media: v2.8.1</summary> ## [v2.8.1](google-resumable-media-v2.8.0...google-resumable-media-v2.8.1) (2026-03-12) ### Bug Fixes * add max_length support to Gzip/Brotli decoders for urllib3 2.6+ (#495) ([cb90060](cb900605)) </details> <details><summary>google-shopping-type: v1.3.0</summary> ## [1.3.0](google-shopping-type-v1.2.0...google-shopping-type-v1.3.0) (2026-03-12) ### Documentation * A comment for message `DestintionEnum` is changed ([505bc97](505bc97)) ### Features * add more values in DestintionEnum ([505bc97](505bc97)) </details> --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

fix: remove deprecated rsa dependency

9f1090c

daniel-sanche requested review from a team as code owners March 3, 2026 23:37

gemini-code-assist Bot reviewed Mar 3, 2026

View reviewed changes

Comment thread packages/google-auth/setup.py Outdated

daniel-sanche and others added 5 commits March 3, 2026 15:41

Apply suggestion from @gemini-code-assist[bot]

2aaf3c3

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

run tests both with and without rsa

8835c83

only duplicate tests on boundary versions

e3e5b12

fixed lint

35e20fc

added type ignore

c739f2a

parthea changed the title ~~fix: remove deprecated rsa dependency~~ fix(google-auth): remove deprecated rsa dependency Mar 5, 2026

parthea marked this pull request as draft March 5, 2026 17:29

daniel-sanche added 2 commits March 6, 2026 10:38

fixed mypy check

bfe3efc

fixed lint

9900ff2

daniel-sanche marked this pull request as ready for review March 6, 2026 18:53

parthea approved these changes Mar 6, 2026

View reviewed changes

daniel-sanche merged commit e8927b9 into main Mar 6, 2026
27 checks passed

daniel-sanche deleted the auth_remove_rsa branch March 6, 2026 19:57

cloud-sdk-librarian-robot mentioned this pull request Mar 12, 2026

chore: librarian release pull request: 20260312T071352Z #16087

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(google-auth): remove deprecated rsa dependency#16020

fix(google-auth): remove deprecated rsa dependency#16020
daniel-sanche merged 8 commits intomainfrom
auth_remove_rsa

daniel-sanche commented Mar 3, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Mar 3, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

daniel-sanche commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 3, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

daniel-sanche commented Mar 3, 2026 •

edited

Loading