chore: Add java-vision diff between monorepo and split-repo by lqiu96 · Pull Request #8472 · googleapis/google-cloud-java · GitHub
Skip to content

chore: Add java-vision diff between monorepo and split-repo#8472

Closed
lqiu96 wants to merge 2 commits into
mainfrom
main-vision_diff_fix
Closed

chore: Add java-vision diff between monorepo and split-repo#8472
lqiu96 wants to merge 2 commits into
mainfrom
main-vision_diff_fix

Conversation

@lqiu96

@lqiu96 lqiu96 commented Sep 27, 2022

Copy link
Copy Markdown
Member

The *.java changes are found in: #8448

Looks to have been reverted as part of #8340

@lqiu96 lqiu96 mentioned this pull request Sep 27, 2022
Closed
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@snippet-bot

snippet-bot Bot commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown

@lqiu96

lqiu96 commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

@meltsufin

meltsufin commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

We probably need to add an exclusion. These are not hand-written samples, but examples for how to use bom vs. without. It's also worth considering keeping these in the monorepo. We should discuss this more.

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
Comment thread java-vision/samples/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud--samples</artifactId>

@lqiu96 lqiu96 Sep 28, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the samples pom.xml has a typo: https://github.com/googleapis/java-vision/blob/2076f657d012d9e02f553f34a663fbd00a75cc28/samples/pom.xml#L5

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
Comment thread java-vision/samples/snapshot/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>-snapshot</artifactId>

@lqiu96 lqiu96 Sep 28, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. https://github.com/googleapis/java-vision/blob/2076f657d012d9e02f553f34a663fbd00a75cc28/samples/snapshot/pom.xml#L5

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
Comment thread java-vision/samples/snippets/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>-snippets</artifactId>

@lqiu96 lqiu96 Sep 28, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as here

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
Comment thread java-vision/samples/install-without-bom/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>-install-without-bom</artifactId>

@lqiu96 lqiu96 Sep 28, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@lqiu96

lqiu96 commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

We probably need to add an exclusion. These are not hand-written samples, but examples for how to use bom vs. without. It's also worth considering keeping these in the monorepo. We should discuss this more.

I think that's fair then. We should probably update the ./delete_non_generated_samples.sh then: https://github.com/googleapis/google-cloud-java/blob/bce011719e8eef293899f29f1cba596e09046225/generation/delete_non_generated_samples.sh

@meltsufin meltsufin added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@meltsufin

meltsufin commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

We probably need to add an exclusion. These are not hand-written samples, but examples for how to use bom vs. without. It's also worth considering keeping these in the monorepo. We should discuss this more.

I think that's fair then. We should probably update the ./delete_non_generated_samples.sh then: https://github.com/googleapis/google-cloud-java/blob/bce011719e8eef293899f29f1cba596e09046225/generation/delete_non_generated_samples.sh

Why don't we see owlbot do this on other PRs in this repo?

@lqiu96

lqiu96 commented Sep 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Web Security Scanner: #8471
It's being added in from this commit (Owl-bot post processor): 11841fa

This PR I opened up for the diffs also has the samples being added in. Also, both PRs seems to have the samples' artifactId being invalid.
<artifactId>-snapshot</artifactId> -- Looking like an error with populating values in the template

@lqiu96

lqiu96 commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

@lqiu96 lqiu96 closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lqiu96 @meltsufin