chore: Display Java Diff between Monorepo and Split Repos by lqiu96 · Pull Request #8448 · googleapis/google-cloud-java · GitHub
Skip to content

chore: Display Java Diff between Monorepo and Split Repos#8448

Closed
lqiu96 wants to merge 1 commit into
mainfrom
main-diff_java
Closed

chore: Display Java Diff between Monorepo and Split Repos#8448
lqiu96 wants to merge 1 commit into
mainfrom
main-diff_java

Conversation

@lqiu96

@lqiu96 lqiu96 commented Sep 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

WIP

@snippet-bot

snippet-bot Bot commented Sep 23, 2022 •
edited
Loading

Copy link
Copy Markdown

@lqiu96 lqiu96 force-pushed the main-diff_java branch 2 times, most recently from 3399111 to 16e7474 Compare September 23, 2022 19:18
@lqiu96 lqiu96 mentioned this pull request Sep 23, 2022
Merged
suztomo
suztomo reviewed Sep 26, 2022
View reviewed changes
Comment thread ...ute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/BaseTest.java Outdated
Comment on lines +28 to +27
return COMPUTE_PREFIX + "-" + placeholder + "-" + UUID.randomUUID().toString().substring(0, 8);
return "gapic-" + placeholder + UUID.randomUUID().toString().substring(0, 8);

@suztomo suztomo Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual commit to monorepo 8e4378d OK to have diff.

suztomo
suztomo reviewed Sep 26, 2022
View reviewed changes
Comment thread ...iner/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java
import com.google.container.v1.ListOperationsResponse;
import com.google.container.v1.NodePool;
import com.google.container.v1.Operation;
import com.google.container.v1.Operation.Status;

@suztomo suztomo Sep 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual commit to monorepo. OK to have diff 8e4378d

@github-actions github-actions Bot force-pushed the main-diff_java branch 6 times, most recently from f43fa85 to 14cbe56 Compare September 26, 2022 20:28
@suztomo

suztomo commented Sep 26, 2022

Copy link
Copy Markdown
Member

You want to have the pull request on the diff script and Java code diff separated.

@github-actions github-actions Bot force-pushed the main-diff_java branch 4 times, most recently from 82d9684 to 67717ec Compare September 27, 2022 15:06
@lqiu96 lqiu96 mentioned this pull request Sep 27, 2022
Closed
@lqiu96

lqiu96 commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

RESOLVED: Data-Catalog Diff

Split Repos: Changes came from googleapis/java-datacatalog#795
Monorepo: Changes were reverted in #8340

Create a PR to revert changes that have been reverted: #8467
MERGED: googleapis/java-datacatalog#857

RESOLVED: Dataproc Diff

Need this PR to be merged in split repos
MERGED: googleapis/java-dataproc#922
MERGED: Need this PR to be merged in monorepo: #8462
Tomo has resolved the issue with the PR.

Web Security Scanner Diff

Should be resolved in: #8471

Java Vision Diff

Should be resolved in: #8472

Java-BigQuery-Data-Exhange

This is an odd difference...

Monorepo PR:

Split Repo PR

Diff in files:

  • Category.java (deleted)
  • CommonProto.java (deleted)
  • pom.xml (modified by Blake)

@github-actions github-actions Bot force-pushed the main-diff_java branch 2 times, most recently from d6f82d2 to 6468782 Compare September 27, 2022 19:47
This was referenced Sep 27, 2022
Closed
Closed
@github-actions github-actions Bot force-pushed the main-diff_java branch 2 times, most recently from 22ced07 to ad8245f Compare September 28, 2022 14:50
@github-actions github-actions Bot force-pushed the main-diff_java branch 3 times, most recently from a308312 to 342ffc0 Compare October 4, 2022 17:50
@suztomo

suztomo commented Oct 4, 2022

Copy link
Copy Markdown
Member

The inifinite diff probably is caused by the recent protobuf changes applied to split repos.

@github-actions github-actions Bot force-pushed the main-diff_java branch 14 times, most recently from 224ba2f to 391b6f7 Compare October 6, 2022 15:13
@tmatsuo tmatsuo mentioned this pull request Oct 6, 2022
Closed
@github-actions github-actions Bot force-pushed the main-diff_java branch 8 times, most recently from b38284d to 2cea3b1 Compare October 7, 2022 15:11
@lqiu96

lqiu96 commented Oct 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@suztomo suztomo mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lqiu96 @suztomo