{{ message }}
fix(storage): add Close() support to AsyncWriterConnectionResumed#16163
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the Close functionality for AsyncWriterConnectionResumed, adding the necessary state tracking, step functions, and resume handling, along with comprehensive unit tests. The review feedback suggests optimizing performance by passing Status objects by value and moving them in OnClose and SetClosed to avoid unnecessary copies, and correcting the misspelled test suite name WriteConnectionResumed to WriterConnectionResumed in the new tests.
kalragauri
force-pushed
the
feature/appendable-close
branch
from
2b28218 to
1da8c41
Compare
v-pratap
reviewed
Jun 24, 2026
v-pratap
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16112. It implements the
Close()API inAsyncWriterConnectionResumedand its internal state managerAsyncWriterConnectionResumedState. This allows resumed async uploads to perform a clean half-close.This PR is similar to the Close implementation for the buffered writer in #16145.