{{ message }}
fix(storage): add Close() support to AsyncWriterConnectionBuffered#16145
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the Close functionality for AsyncWriterConnectionBuffered and its internal state, including handling close steps, state resumption on failures, and adding corresponding unit tests. The review feedback highlights two issues: first, a critical bug where CloseStep may be triggered before the resend_buffer_ is fully drained, leading to data loss; second, a potential issue where subsequent calls to Close() return an invalid future because closed_future_ is moved on the first invocation.
kalragauri
force-pushed
the
feature/appendable-close
branch
from
bc69cf7 to
fe49ad5
Compare
v-pratap
approved these changes
Jun 11, 2026
kalragauri
force-pushed
the
feature/appendable-close
branch
from
c2dd166 to
a253210
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16112. It implements the Close() API in
AsyncWriterConnectionBufferedand its internal state managerAsyncWriterConnectionBufferedState. This allows buffered async uploads to perform a clean half-close after ensuring all previously buffered data is fully flushed.