{{ message }}
Repository navigation
Advise --relock for composite-held exact tags behind their commit - #221
Merged
Merged
Conversation
Since --relock rebuilds composite closures from live manifests, it locks a composite-held exact tag at the tag's commit. Drop the advice that it only helps once the composite advances, and test the repair end to end. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
2 open issues
What changed in this PR
Updates --relock guidance and behavior expectations so exact-tag entries locked behind a tag can be repaired via relock, including when referenced from within a composite action.
Changes:
- Update tag/commit mismatch remediation text to recommend
gh actions-lock --relockmore broadly. - Adjust parity test to assert that
--relockrepairs an exact-tag-behind scenario originating from a composite action reference. - Refresh README documentation to match the updated
--relockbehavior.
Review effort: Lite
Comment on lines
+2996
to
+2998
| assert.Contains(t, string(after), "'actions/checkout@v7.0.1':\n ref: 'v7.0.1'\n commit: 'sha1-"+parityTestMoved+"'", "the tag's commit is written") | ||
| assert.NotContains(t, string(after), parityTestSHA, "the older commit is not") | ||
| assert.Contains(t, string(after), "sha1-"+rootSHA, "the composite keeps its commit") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--relockrebuilds composite closures from live manifests, so a composite-held exact tag that is locked behind its commit is now relocked at the tag's commit. The advice now says to rungh actions-lock --relockand no longer says that only upgrading the composite helps. The README is updated to match.TestParity_ExactTagBehindInCompositeNamesHolder, which has been failing on main, is replaced by a test that runs--relock, checks it writes the tag's commit, and then checks--verifypasses.