{{ message }}
Repository navigation
Verify and rebuild complete transitive lock graphs - #214
Merged
Merged
Conversation
nodeselector
added this pull request to stack #216
October 21, 2026 04:14
nodeselector
removed this pull request from stack #216
October 21, 2026 04:15
nodeselector
changed the base branch from
nodeselector-transitive-lock-graphs-f92
to
main
October 21, 2026 04:16
There was a problem hiding this comment.
🟡 Changes recommended
Graph rebuilding can remove dependencies still required by composite manifests or unselected workflows.
4 open issues
What changed in this PR
Strengthens transitive dependency graph validation and rebuilding in gh-actions-lock.
Changes:
- Adds graph-fault checks during verification and before writes.
- Rebuilds selected closures with
--relockand--accept-moved. - Updates documentation and regression tests.
Review effort: Max
--verify-local and --verify report a recorded edge with no entry, or a cycle, as a blocking finding that points at --relock, and a write refuses to leave a workflow's closure incomplete. Set replaces a composite's uses: when the run read its manifest and keeps them for entries reused from the lock, and --relock and --accept-moved rebuild every selected workflow's closure even when no ref moved. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…kfile A run's manifest reads cover only the sub-actions it uses, so entries that workflows the run doesn't write reach keep their recorded edges. A use a composite also declares keeps its ref, so narrowing can't move the composite's edge. A missing entry is an incomplete-lockfile finding, which renderers show with its --relock remediation; the loader already rejects cycles, so the walker no longer looks for them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
nodeselector
force-pushed
the
nodeselector-whole-lock-graph
branch
from
October 21, 2026 04:44
cc69e16 to
cbacc15
Compare
nodeselector
added this pull request to stack #218
October 21, 2026 04:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--verify-localand--verifyreport a recordeduses:edge with no dependencies entry as anincomplete-lockfileerror pointing atgh actions-lock --relock, and a write refuses to leave a workflow's lock graph incomplete.--relockand--accept-movedrebuild every selected workflow's closure from live manifests even when no ref moved, leaving recorded roots and uses a composite declares as they are.