Update to remove smimesign from Linux instructions by N6UDP · Pull Request #32306 · github/docs · GitHub
Skip to content

Update to remove smimesign from Linux instructions - #32306

Merged
nguyenalex836 merged 1 commit into
github:mainfrom
N6UDP:smimesignnolinux
Apr 1, 2024
Merged

Update to remove smimesign from Linux instructions#32306
nguyenalex836 merged 1 commit into
github:mainfrom
N6UDP:smimesignnolinux

Conversation

@N6UDP

@N6UDP N6UDP commented Mar 30, 2024

Copy link
Copy Markdown
Contributor

Why:

#31465 was rejected because it added docs for gpgsm (X509 signing that works on Linux) - this at least clears up the fact smimesign does not work on Linux.

Closes:
github/smimesign#45
Related to:
github/smimesign#30

What's being changed (if available, include any code snippets, screenshots, or gifs):

Remove smimesign from Linux docs

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Mar 30, 2024
@N6UDP

N6UDP commented Mar 30, 2024

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Mar 30, 2024

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Apr 1, 2024
@nguyenalex836

nguyenalex836 commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

@N6UDP Thanks so much for opening a PR with this fix! I'll get this merged 🍏

@nguyenalex836
nguyenalex836 added this pull request to the merge queue Apr 1, 2024
Merged via the queue into github:main with commit 2f69738 Apr 1, 2024
@github-actions

github-actions Bot commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees

No one assigned

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@N6UDP @nguyenalex836