Update SMIME instructions for Linux/WSL2 by N6UDP · Pull Request #31465 · github/docs · GitHub
Skip to content

Update SMIME instructions for Linux/WSL2 - #31465

Closed
N6UDP wants to merge 6 commits into
github:mainfrom
N6UDP:patch-1
Closed

N6UDP wants to merge 6 commits into
github:mainfrom
N6UDP:patch-1

Conversation

@N6UDP

@N6UDP N6UDP commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

Why:

Closes:
github/smimesign#30
github/smimesign#45

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding information for GPGSM on Linux and a note for both Windows and Linux about how to configure it on WSL2.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome

welcome Bot commented Feb 6, 2024

Copy link
Copy Markdown

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 6, 2024
@github-actions

github-actions Bot commented Feb 6, 2024 •

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Feb 6, 2024
@nguyenalex836

Copy link
Copy Markdown
Contributor

@N6UDP Thanks for opening a PR! ✨

It looks like this is still a draft. Could you ping me when this is ready? Then, I'll get it up for review ⚡

@N6UDP
N6UDP marked this pull request as ready for review February 10, 2024 08:01
@N6UDP

N6UDP commented Feb 10, 2024

Copy link
Copy Markdown
Contributor Author

@nguyenalex836 this should be good to go now.

@nguyenalex836 nguyenalex836 added the waiting for review Issue/PR is waiting for a writer's review label Feb 12, 2024
@nguyenalex836

Copy link
Copy Markdown
Contributor

@N6UDP Awesome, thanks for letting me know! This has been triaged for review ✨

@jc-clark

jc-clark commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Hey @N6UDP thank you for the contribution. We checked in with our engineering team on this and GitHub doesn't officially support gpgsm. As such, we won't add documentation to our public docs for this use case. I'll go ahead and close this PR.

@jc-clark jc-clark closed this Mar 6, 2024
@N6UDP

N6UDP commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

@jc-clark even we don't want to add docs related to gpgsm you all should clarify the existing docs as they currently imply that smimesign is supported on linux which it is not.

@jc-clark

Copy link
Copy Markdown
Contributor

I see what you're saying here, @N6UDP thank you for the feedback. I can work with our team on the best follow up for that.

@jc-clark

Copy link
Copy Markdown
Contributor

@nguyenalex836 nguyenalex836 added help wanted Anyone is welcome to open a pull request to fix this issue and removed waiting for review Issue/PR is waiting for a writer's review help wanted Anyone is welcome to open a pull request to fix this issue labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants