{{ message }}
Repository navigation
fix(generators): add targeted pnpm build approval for sqlite3 and esbuild - #3710
Open
akasakariko wants to merge 1 commit into
Open
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #3709
Summary
--allow-build=sqlite3when installingsqlite3under pnpm--allow-build=esbuildwhen installing@feathersjs/cliunder pnpm because the CLI TypeScript loader requiresesbuildTesting
ERR_PNPM_IGNORED_BUILDSonsqlite3@6.0.1, blockingdevDependenciesinstallation, and blockedesbuildpostinstall in CLI dependenciespackages/generators/test/install.test.tsfor npm, yarn, and pnpm argument composition, versioned and unversioned requests, callable arguments, and error propagationdevDependenciespresent, verified native SQLite query execution, passedpnpm test(3 passing), and ranpnpm run compilegit diff --check