fix(generators): add targeted pnpm build approval for sqlite3 and esbuild by akasakariko · Pull Request #3710 · feathersjs/feathers · GitHub
Skip to content

fix(generators): add targeted pnpm build approval for sqlite3 and esbuild - #3710

Open
akasakariko wants to merge 1 commit into
feathersjs:dovefrom
akasakariko:fix/pnpm-build-approval
Open

akasakariko wants to merge 1 commit into
feathersjs:dovefrom
akasakariko:fix/pnpm-build-approval

Conversation

@akasakariko

Copy link
Copy Markdown
Contributor

Fixes #3709

Summary

  • Pass targeted --allow-build=sqlite3 when installing sqlite3 under pnpm
  • Pass targeted --allow-build=esbuild when installing @feathersjs/cli under pnpm because the CLI TypeScript loader requires esbuild
  • Support both versioned and unversioned package requests while avoiding false matches on similarly named packages
  • Keep npm and yarn install commands unchanged
  • Avoid blanket script execution permissions and preserve standard install failure propagation

Testing

  • Verified failure before fix: pnpm 12.9.1 threw ERR_PNPM_IGNORED_BUILDS on sqlite3@6.0.1, blocking devDependencies installation, and blocked esbuild postinstall in CLI dependencies
  • Added 19 regression tests in packages/generators/test/install.test.ts for npm, yarn, and pnpm argument composition, versioned and unversioned requests, callable arguments, and error propagation
  • Ran 20 focused tests on Node 20 and Node 24
  • Passed all 60 generator tests across JavaScript, TypeScript, Koa, Express, TypeBox, and JSON schema combinations
  • Verified default app generation with pnpm 12.9.1: confirmed devDependencies present, verified native SQLite query execution, passed pnpm test (3 passing), and ran pnpm run compile
  • Verified monorepo compilation for all 25 projects, Prettier, ESLint, and git diff --check
  • GitHub CI has not yet run and the full monorepo test suite was not run locally

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm project missing dev dependencies

1 participant