{{ message }}
Repository navigation
Conversation
Keep the Receive list in sync with addresses found during scanning. This fixes missing addresses and crashes when creating a new address after restoring a wallet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After restoring a wallet that had received to a subaddress #11 or higher, the Receive tab stops at #10, and creating a new address can crash Feather after
QSortFilterProxyModel: invalid inserted rows reported by source model(#243).Cause:
MainWindow::onWalletOpened). While scanning, wallet2 adds every subaddress it receives to (an output to Ledger Nano S Plus device is not recognized #13 makes 14 addresses), but since c5aef15 the synchronized callbacks only callSubaddress::updateUsed, which walks the rows already in the list.Subaddress::addRowtakes the new row's index from wallet2, so it announces row 14 to a model with 11 rows.emplaceRowrefuses that row, the result is ignored, and the proxy is told about a row that does not exist. The same happens without a click when every listed address is used, throughnoUnusedSubaddresses.refresh().The change adds
Subaddress::appendRows(), which appends the addresses wallet2 knows and the list does not, throughemplaceRowand its existing checks, with the insert signals only around a row it accepted.updateUsedcalls it before looking for an unused address, andaddRowcalls it after creating one. If a row fails the checks, it falls back torefresh()and its corruption handling. Ordinary blocks still do not reset the model.beginInsertRowsnow gets the root index explicitly.Fixes #243
Testing: built in a Linux container with the CI's Ubuntu 24.04 steps (
cmake -DWITH_SCANNER=OFF .. && cmake --build . -j $(nproc)). Reproduced on a local regtest node (monerod --regtest --offline, v0.18.5.4): a wallet received to #1–#10 and #13, was restored from its seed into a new file and opened in Feather under Xvfb. Without the change, after synchronization the Receive tab showed only #0–#10 and Feather logged the warning above; after Create new address it crashed (SIGSEGV) as soon as the table was clicked. With the change, #11–#13 appear after synchronization with the original wallet's addresses, Create new address adds #14, the model warning does not appear, and Feather quits normally.Prepared with AI assistance.
🤖 Generated with Claude Code