Use IRootFunctions in Tensor.StdDev by lilinus · Pull Request #110641 · dotnet/runtime · GitHub
Skip to content

Use IRootFunctions in Tensor.StdDev#110641

Merged
tannergooding merged 14 commits into
dotnet:mainfrom
lilinus:tensor-stddev-use-root
Jan 29, 2025
Merged

Use IRootFunctions in Tensor.StdDev#110641
tannergooding merged 14 commits into
dotnet:mainfrom
lilinus:tensor-stddev-use-root

Conversation

@lilinus

@lilinus lilinus commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Continuation of #110392

Fixes #110772

Note: this is a breaking change on an experimental API.

@ghost

ghost commented Dec 12, 2024

Copy link
Copy Markdown

1 similar comment
@ghost

ghost commented Dec 12, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Dec 12, 2024
@lilinus

lilinus commented Dec 12, 2024

Copy link
Copy Markdown
Contributor Author

I'm not managing to generate any changes to the relevant CompatibilitySuppressions.xml even if I build with /p:ApiCompatGenerateSuppressionFile=true argument.

Can't find any documentation on what the format to do the changes manually.

@hez2010

hez2010 commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Can't find any documentation on what the format to do the changes manually.

Try running build.cmd -s libs /p:ApiCompatGenerateSuppressionFile=true

@lilinus

lilinus commented Dec 14, 2024

Copy link
Copy Markdown
Contributor Author

@tannergooding tannergooding merged commit 3688b59 into dotnet:main Jan 29, 2025
grendello added a commit to grendello/runtime that referenced this pull request Jan 30, 2025
* main: (31 commits)
  More native AOT Pri-1 test tree bring up (dotnet#111994)
  Fix BigInteger outerloop test (dotnet#111841)
  JIT: Run 3-opt once across all regions (dotnet#111989)
  JIT: Check for profile consistency throughout JIT backend (dotnet#111684)
  [JIT] Add legacy extended EVEX encoding and EVEX.ND/NF feature to x64 emitter backend (dotnet#108796)
  [iOS][globalization] Fix IndexOf on empty strings on iOS to return -1 (dotnet#111898)
  System.Speech: Use intellisense xml from dotnet-api-docs (dotnet#111983)
  [mono][mini] Disable inlining if we encounter class initialization failure (dotnet#111754)
  [main] Update dependencies from dotnet/roslyn (dotnet#111946)
  Update dependencies from https://github.com/dotnet/arcade build 20250129.2 (dotnet#111996)
  Try changing the ICustomQueryInterface implementation to always return NotHandled instead of Failed to defer back to the ComWrappers impl. (dotnet#111978)
  Combined dependency update (dotnet#111852)
  Replace OPTIMIZE_FOR_SIZE with feature switch (dotnet#111743)
  Fix failed assertion 'FPbased == FPbased2' (dotnet#111787)
  Add remark to `ConditionalSelect` (dotnet#111945)
  JIT: fix try region cloning when try is nested in a handler (dotnet#111975)
  Use IRootFunctions in Tensor.StdDev (dotnet#110641)
  Remove zlib dependencies from Docker containers (dotnet#111939)
  Avoid `Unsafe.As` for `Memory<T>` and `ReadOnlyMemory<T>` conversion (dotnet#111023)
  Cleanup membarrier portability (dotnet#111943)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Numerics.Tensors community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tensor.StdDev does not handle non-contiguous input

4 participants