{{ message }}
Fix TensorExtensions.StdDev#110392
Merged
Merged
Conversation
ghost
added
the
dotnet-policy-service
Bot
added
the
community-contribution
This was referenced Dec 4, 2024
michaelgsharp
approved these changes
Dec 11, 2024
Member
There was a problem hiding this comment.
This should indeed be updated to use IRootFunctions instead; not Pow which isn't guaranteed to behave the same in many important edge cases
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110381
I use
IPowerFunctions<T>.Pow(x, 0.5)to replicate sqrt, but special casedoubleandfloatto useMath.SqrtandMathF.Sqrtrespectively.Would prefer to add
IRootFunctionsto method constraints to useT.Sqrtbut I don't know if it is possible to add new constraints.N.b.
TensorExtensionsis still marked as experimental