Revert "[dotnet] Pass --preserve-symbol-paths to the trimmer to ensure trimmed assemblies aren't different between architectures. (#23858)"#24173
Conversation
…e trimmed assemblies aren't different between architectures. (#23858)" This reverts commit dc79f3e. The problem is that we need the assembly to point to the linked version of the pdb, otherwise the debugger will refuse to load debug info, saying the pdb doesn't match the dll. Eventually we might need a way to write just the filename of the pdb in the assembly, and not a full path, that that's a much more involved fix. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2614232.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #a13a747] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #a13a747] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #a13a747] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #a13a747] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #a13a747] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #a13a747] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #a13a747] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
4 participants
This reverts commit dc79f3e.
The problem is that we need the assembly to point to the linked version of the
pdb, otherwise the debugger will refuse to load debug info, saying the pdb
doesn't match the dll.
Eventually we might need a way to write just the filename of the pdb in the
assembly, and not a full path, that that's a much more involved fix (#24174).
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2614232.