{{ message }}
[dotnet] Pass --preserve-symbol-paths to the trimmer to ensure trimmed assemblies aren't different between architectures.#23858
Merged
Conversation
…d assemblies aren't different between architectures.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Collaborator
✅ [PR Build #3dd6981] Build passed (Detect API changes) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
✅ [CI Build #3dd6981] Build passed (Build macOS tests) ✅Pipeline on Agent |
Collaborator
💻 [CI Build #3dd6981] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
Collaborator
💻 [CI Build #3dd6981] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
Collaborator
💻 [CI Build #3dd6981] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
Collaborator
💻 [CI Build #3dd6981] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
Collaborator
💻 [CI Build #3dd6981] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
dalexsoto
approved these changes
Sep 22, 2025
rolfbjarne
added a commit
that referenced
this pull request
Nov 4, 2025
…e trimmed assemblies aren't different between architectures. (#23858)" This reverts commit dc79f3e. The problem is that we need the assembly to point to the linked version of the pdb, otherwise the debugger will refuse to load debug info, saying the pdb doesn't match the dll. Eventually we might need a way to write just the filename of the pdb in the assembly, and not a full path, that that's a much more involved fix. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2614232.
rolfbjarne
added a commit
that referenced
this pull request
Nov 5, 2025
…e trimmed assemblies aren't different between architectures. (#23858)" This reverts commit dc79f3e. The problem is that we need the assembly to point to the linked version of the pdb, otherwise the debugger will refuse to load debug info, saying the pdb doesn't match the dll. Eventually we might need a way to write just the filename of the pdb in the assembly, and not a full path, that that's a much more involved fix. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2614232.
rolfbjarne
added a commit
that referenced
this pull request
Nov 5, 2025
…e trimmed assemblies aren't different between architectures. (#23858)" This reverts commit dc79f3e. The problem is that we need the assembly to point to the linked version of the pdb, otherwise the debugger will refuse to load debug info, saying the pdb doesn't match the dll. Eventually we might need a way to write just the filename of the pdb in the assembly, and not a full path, that that's a much more involved fix. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2614232.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.