{{ message }}
Repository navigation
Preserve the schedule while its time input is incomplete - #1168
Merged
WaylandYang merged 2 commits intoOct 10, 2026
Merged
WaylandYang merged 2 commits into
WaylandYang merged 2 commits into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
WaylandYang
approved these changes
Oct 10, 2026
WaylandYang
left a comment
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this. Confirmed: a weekday click while the time box held something like 25:00 sent a schedule the server refuses; the guard now uses the same pattern as the input. Checked on top of dev together with the other fixes from this batch that we are taking: typecheck clean, web tests and the affected crate tests pass. Thanks again.
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing weekdays while the time field is incomplete bypasses its input validation and submits a malformed or silently changed cron. Validate the complete time before any daily/weekly emission so the last valid schedule remains intact.
Validation: three actual weekday-handler regressions fail on baseline behavior (exported only for test access); all four invalid/valid controls pass fixed with the state-hook boundary controlled. Typecheck, style guard and production build pass.