{{ message }}
Add dark theme support for byjus.com#14509
Closed
AmrendraTheCoder wants to merge 4 commits into
Closed
Conversation
AmrendraTheCoder
commented
Jul 20, 2025
AmrendraTheCoder
commented
Contributor
- Invert logos and brand elements for better dark mode visibility
- Fix search box background to use neutral background color
- Minimal targeted fixes for essential UI elements
- Invert logos and brand elements for better dark mode visibility - Fix search box background to use neutral background color - Minimal targeted fixes for essential UI elements
Myshor
requested changes
Jul 20, 2025
Myshor
left a comment
Myshor
left a comment
Collaborator
There was a problem hiding this comment.
Found some issues applying this fix.
Collaborator
There was a problem hiding this comment.
This selector if you realy need to use it on some picture must be changed to be less general.
I found it breaks some pics on page I landed when I started check.
Same little lower on the same page:
Contributor
Author
There was a problem hiding this comment.
alright let me fix it.
- Make image selectors more specific to target only header/nav logos - Prevent content images from being inappropriately inverted - Scope img[alt] selectors to header, nav, navbar contexts only Resolves feedback from PR review about broken content images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.