Fix/indian websites dark theme#14485
Conversation
- Add comprehensive logo and icon inversion rules for GeeksforGeeks branding - Improve search functionality styling with better contrast and visibility - Enhance code blocks and syntax highlighting for better readability - Add proper styling for navigation, buttons, forms, and interactive elements - Include fixes for course content, quizzes, comments, and media players - Improve table, modal, and notification styling consistency - Add comprehensive coverage for educational platform UI elements Fixes visual issues with logos being invisible on dark backgrounds and improves overall user experience across all GeeksforGeeks pages.
- Add amazon.in: E-commerce platform with logo inversion and UI styling - Add byjus.com: Educational platform with course cards and video player fixes - Add flipkart.com: E-commerce with comprehensive product card styling - Add indianexpress.com: News website with article cards and navigation - Add myntra.com: Fashion e-commerce with product filters and cart styling - Add ndtv.com: News platform with live updates and breaking news styling - Add paytm.com: Payment platform with service cards and transaction UI - Add phonepe.com: UPI payment app with feature cards and secure styling - Add swiggy.com: Food delivery with restaurant cards and order interface - Add thehindu.com: Premium news site with subscription and editorial styling - Add unacademy.com: Educational platform with course progress and live classes - Add vedantu.com: Online tutoring with video sessions and doubt resolution - Add zomato.com: Restaurant discovery with ratings and delivery options All sites include: ✅ Logo and icon inversion for proper visibility on dark backgrounds ✅ Navigation and header styling with proper contrast ✅ Search functionality with dark theme compatibility ✅ Card layouts and content areas with appropriate shadows ✅ Button styling with brand-appropriate gradients ✅ Interactive elements with hover states and focus indicators ✅ Mobile app promotion badges and social media icons Enhances Dark Reader experience for 500M+ Indian internet users.
alexanderby
left a comment
alexanderby
left a comment
There was a problem hiding this comment.
Generally looks good. I only wish that only necessary things get fixed, so that this file stays as small as possible and remain easily maintainable. The websites don't have to be 100% ideal. If you see some website looks totally broken, or there is some common patter (like all the icons or all the text are black on black), it could be better to submit an issue, so that we can come up with an idea of how to improve our algorithms.
|
|
||
| ================================ | ||
|
|
||
| amazon.in |
There was a problem hiding this comment.
Please use amazon.* section.
| background: var(--darkreader-neutral-background) !important; | ||
| border-bottom: 1px solid var(--darkreader-neutral-border) !important; | ||
| } | ||
|
|
There was a problem hiding this comment.
CSS section should not have empty lines.
There was a problem hiding this comment.
Will fix that by today itself.
| box-shadow: ${rgba(0, 0, 0, 0.3)} 0px 0px 2px !important; | ||
| } | ||
|
|
||
| /* Header and Navigation improvements */ |
There was a problem hiding this comment.
Comments should be removed.
- Remove duplicate amazon.in section (amazon.* already covers it) - Saves 72 lines following maintainer feedback for minimal fixes only Addresses maintainer feedback: ✅ Use amazon.* instead of amazon.in ✅ Keep configurations minimal and maintainable
- Reduced from 468 lines to 9 lines, saving 459 lines - Removed extensive CSS theming and comments - Kept only critical logo inversions and search box fix - Follows maintainer feedback for minimal, maintainable fixes
- zomato.com: 60 lines → 9 lines (saved ~51 lines) - vedantu.com: 67 lines → 9 lines (saved ~58 lines) - unacademy.com: 67 lines → 9 lines (saved ~58 lines) Total saved in this batch: ~167 lines Removed extensive CSS theming, kept only critical logo inversions Progress: 4/13 Indian websites minimized (amazon.*, geeksforgeeks, zomato, vedantu, unacademy)
… swiggy.com, phonepe.com - saved ~194 lines
…sion accomplished! - flipkart.com: 70+ lines → 9 lines - byjus.com: 67+ lines → 11 lines Final transformation: 1438 lines → ~255 lines saved All 13 Indian websites + amazon.* + geeksforgeeks.org minimized! ✅ Only essential fixes (logos, critical search elements) ✅ No extensive CSS theming ✅ No comments or empty lines ✅ File remains small and maintainable per maintainer feedback
|
Hi @alexanderby! I've completely reworked this PR based on your feedback: Before: 1,438 lines of comprehensive theming ✅ All feedback addressed:
Each website now has ~9 minimal lines instead of 60+ comprehensive theming lines, following the project's philosophy of fixing only broken elements. Ready for review! 🙏 |
There was a problem hiding this comment.
I won't touch anything from here. I already mentioned geeksforgeeks.org.
You already learned about "smaller PR faster review and easier approach".
I propose something like this:
- Close this PR as I won't merge it and won't check all new entries added here.
- Make one PR for one site - it will be easier to check and give some feedback if something needs changes or can be merged as it is.
I know it will need again more work on your side but it will be easier to mantain these new PRs and merge all what will be checked and OK for us then leave the other that would need some changes. 😉
|
|
||
| ================================ | ||
|
|
||
| geeksforgeeks.org |
There was a problem hiding this comment.
This part was already fixed in other PR so it's needed to be removed from here.
There was a problem hiding this comment.
Yea, Okay.
|
Or leave the fix for Alexander to review but still as we have fixes for |
Hi @Myshor, Yea I understood it but right now I am closing this PR and creating individual PR for each sit. |
3 participants
No description provided.