{{ message }}
Fix false positive on concept declaration#288
Merged
Conversation
aaronliu0130
approved these changes
Sep 10, 2024
aaronliu0130
left a comment
aaronliu0130
left a comment
Member
There was a problem hiding this comment.
This is a massive step up, though there is the very rare case of an identifier being named "requires" and the user linting a pre-C++20 file. It would be great if we could work out a way to also require the "concept" keyword, but I would be happy to merge this as-is if you can't figure it out.
Contributor
Author
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to fix #225, since #229 seems to be dead.
I used a
requireskeyword for concept detection, as theconceptkeyword could be a few lines above the opening brace.Not 100% on the regex, so if someone could check it, I would appreciate it.