{{ message }}
Fix false positive readability/braces warning for trailing comma on c…#229
Closed
jordancharest wants to merge 1 commit into
Closed
Fix false positive readability/braces warning for trailing comma on c…#229jordancharest wants to merge 1 commit into
jordancharest wants to merge 1 commit into
Conversation
Author
aaronliu0130
requested changes
Mar 31, 2024
aaronliu0130
left a comment
aaronliu0130
left a comment
Member
There was a problem hiding this comment.
Would you kindly write some tests? Also, I doubt that this would work on multi-line concepts. Maybe we could take some inspiration from structs' detection.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oncepts.
Currently a readability/braces error is triggered for C++20 concepts. This change ignores trailing semi-colons that follow concept definitions.