Feature/allow empty commit - #592
Conversation
|
@Lee-W Can you elaborate about what bother you in this test case ? |
|
I'm kinda not sure whether this is correctly tested and will need sometime to figure it out. Will try to check it this week |
Lee-W
added
pr-status: wait-for-review
and removed
issue-status: wait-for-response
labels
|
Hi, I think we have a misunderstanding here. When I say "Empty commit" I mean a commit with no changes in it but we still need a message inside. |
| "footer": "", | ||
| } | ||
|
|
||
| commit_mock = mocker.patch("commitizen.git.commit") |
There was a problem hiding this comment.
@Dranaxel Thanks for correcting me. Yes, you're right. In that case, we probably should assert whether this function is called with --allow-empty. This can be done by something likeassert_called_with.
There was a problem hiding this comment.
Sorry i'm not sure about what you mean/how to use assert_called_with. Are you suggesting to assert the flag allow-empty was here when le command was launched ?
There was a problem hiding this comment.
assert --allow-empty is actually passed into commitizen.git.commit when the operation above is executed
Lee-W
added
issue-status: wait-for-response
and removed
pr-status: wait-for-review
labels
Lee-W
added
pr-status: wait-for-response
and removed
issue-status: wait-for-response
labels
There was a problem hiding this comment.
Need rebase but I am OK with this one. I can definitely see use cases where you just want to force a commit without changes (like forcing rebuild to have updated dependencies).
Note: we might want the bump counter part for the same reason, aka. being able to force a release not containing commits eligible to changelog (aka. #723)
|
Commitizen has |
4 participants
Description
Add allow to create empty commit
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Allow to invoke cz and create a commit without any change in it
Additional context
Relates to #247 & #590