{{ message }}
feat(commit): add '--allow-empty' flag to commit command - #1217
Merged
Conversation
AdrianDC
changed the title
Member
|
Hi, thanks for contributing! would like to know why do we want |
Contributor
Author
|
Coverage fixed 👍. Lee-W, apart from regular usage, it's because the staging area checks fail : $ cz c --allow-empty
-Invalid commitizen arguments were found: `--allow-empty`. Please use -- separator for extra git args
$ cz c -- --allow-empty
-No files added to staging!
# =======================
$ pipx uninstall commitizen; pipx install .
uninstalled commitizen! ✨ 🌟 ✨
installed package commitizen 3.29.0, installed using Python 3.12.3
These apps are now globally available
- cz
- git-cz
done! ✨ 🌟 ✨
# =======================
$ cz c --allow-empty
? Select the type of change you are committing feat: A new feature. Correlates with MINOR in SemVer
? What is the scope of this change? (class or file name): (press [enter] to skip)
test
? Write a short and imperative summary of the code changes: (lower case and no period)
test
? Provide additional contextual information about the code changes: (press [enter] to skip)
? Is this a BREAKING CHANGE? Correlates with MAJOR in SemVer No
? Footer. Information about Breaking Changes and reference issues that this commit closes: (press [enter] to skip)
feat(test): test
[master 6b9618c5] feat(test): test
+Commit successful! |
Lee-W
reviewed
Aug 22, 2024
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
4 tasks
Contributor
Author
|
As discussed, I redid it all into Tested locally with |
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
AdrianDC
force-pushed
the
allow-empty
branch
from
November 10, 2024 10:51
217e255 to
556ae98
Compare
Contributor
Author
|
Rebased, ready to roll after 1206 👍 |
Member
|
1206 merged 🙌 |
Signed-off-by: Adrian DC <radian.dc@gmail.com>
AdrianDC
force-pushed
the
allow-empty
branch
from
November 16, 2024 11:42
556ae98 to
a442d70
Compare
Contributor
Author
Lee-W
self-requested a review
November 20, 2024 02:43
Lee-W
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat(commit): add '--allow-empty' flag to commit command
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Allow to invoke cz and create a commit without any change in it
Steps to Test This Pull Request
Additional context