feat(helm): make imagePullPolicy configurable in StatefulSet by safijunaid17 · Pull Request #20296 · bytebase/bytebase · GitHub
Skip to content

feat(helm): make imagePullPolicy configurable in StatefulSet #20296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
safijunaid17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(helm): make imagePullPolicy configurable in StatefulSet #20296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm-charts/bytebase/README.md
View file
Open in desktop
7 changes: 5 additions & 2 deletions helm-charts/bytebase/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# bytebase
{{- $extraSecretMounts := .Values.bytebase.extraSecretMounts -}}
{{- $extraVolumes := .Values.bytebase.extraVolumes }}
# imagePullPolicy
{{- $pullPolicy := .Values.bytebase.imagePullPolicy | default "Always" -}}
{{- $busyboxPullPolicy := .Values.bytebase.busyboxPullPolicy | default "IfNotPresent" -}}
# bytebase.option
{{- $port := .Values.bytebase.option.port -}}
{{- $data := .Values.bytebase.option.data -}}
Expand Down Expand Up @@ -59,7 +62,7 @@ spec:
initContainers:
- name: init-container
image: {{ include "bytebase.busyboxImage" . }}
imagePullPolicy: IfNotPresent
imagePullPolicy: {{ $busyboxPullPolicy }}
env:
- name: PG_PASSWORD
{{- if $externalPgExistingPgPasswordSecret }}
Expand Down Expand Up @@ -115,7 +118,7 @@ spec:
containers:
- name: bytebase
image: {{ include "bytebase.image" . }}
imagePullPolicy: Always
imagePullPolicy: {{ $pullPolicy }}
env:
{{- if $externalPgExistingPgURLSecret }}
# If user specifies an existing secret, we should read the external pg connection string in that secret.
Expand Down
4 changes: 4 additions & 0 deletions helm-charts/bytebase/values.yaml
View file
Open in desktop