Repository navigation
feat(helm): make imagePullPolicy configurable in StatefulSet - #20296
safijunaid17 wants to merge 1 commit into
Conversation
1 similar comment
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA and add your name to contributors list. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f04d080b01
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
safijunaid17
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adc0f6dc10
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| apiVersion: v2 | ||
| name: bytebase | ||
| version: 1.1.5 | ||
| version: 1.1.6 |
There was a problem hiding this comment.
This bumps the chart to 1.1.6, but the repository’s Helm packaging script writes the published .tgz and merged index into docs (scripts/package_helm.sh lines 12-17), and docs/index.yaml still only advertises bytebase-1.1.5.tgz. Since the install docs point users at the GitHub Pages chart repo, chart-repo users will not receive this new configurable pull-policy chart unless the 1.1.6 package and index entry are committed with the version bump.
Useful? React with 👍 / 👎.
The Bytebase container hardcoded imagePullPolicy: Always and the BusyBox init container hardcoded IfNotPresent. Air-gapped and mirrored-registry installs need to override both. Add bytebase.imagePullPolicy and bytebase.busyboxPullPolicy, defaulting to the previous hardcoded values so rendered output is unchanged by default.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de2ea00901
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Because this change adds new rendered chart values while helm-charts/bytebase/Chart.yaml still declares version 1.1.5, the GitHub Pages chart repo would have to republish bytebase-1.1.5.tgz in place for users to receive these knobs. Helm chart versions are expected to be immutable, and users with the existing 1.1.5 package/cache may not pick up the new pull-policy fields; bump the chart version and publish the corresponding package/index entry with this chart change.
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
This PR introduces configurable imagePullPolicy parameters for both the main Bytebase container and the initialization container.
Rationale:
Hardcoding imagePullPolicy: Always can lead to deployment failures in environments with strict Admission Controllers (such as Kyverno or OPA Gatekeeper) that enforce best practices. By allowing users to specify the pull policy, we ensure compliance with organizational security and resource optimization requirements.
Furthermore, while Always is useful for mutable tags like :latest, standard production workflows rely on specific versioning where IfNotPresent is preferred to reduce unnecessary network egress and improve pod startup latency.