feat: add conditions around CodeArtifact publishing and CodeCov by maxday · Pull Request #504 · aws/aws-lambda-java-libs · GitHub
Skip to content

feat: add conditions around CodeArtifact publishing and CodeCov - #504

Merged
maxday merged 11 commits into
mainfrom
maxday/remove-aws-publishing-action
Aug 7, 2024
Merged

maxday merged 11 commits into
mainfrom
maxday/remove-aws-publishing-action

Conversation

@maxday

@maxday maxday commented Aug 6, 2024 •

Copy link
Copy Markdown
Member

Description of changes:

  • protects publishing artifact with a check against ENABLE_SNAPSHOT
  • protects publishing CodeCov with a check against CODECOV_TOKEN

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov

codecov Bot commented Aug 6, 2024

Copy link
Copy Markdown

@maxday maxday changed the title feat: disable CodeArtifact publishing, enable CodeCov publishing feat: add conditions around CodeArtifact publishing and CodeCov Aug 7, 2024

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxday
maxday merged commit 8af7655 into main Aug 7, 2024
@maxday
maxday deleted the maxday/remove-aws-publishing-action branch August 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants