{{ message }}
[#1456] improvement(client): Better exception handling when calling requireBuffer using GRPC#1457
Merged
Merged
Conversation
Contributor
Author
…ling requireBuffer using GRPC
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
============================================
+ Coverage 54.19% 55.12% +0.92%
+ Complexity 2775 2773 -2
============================================
Files 423 403 -20
Lines 24185 21854 -2331
Branches 2058 2062 +4
============================================
- Hits 13108 12047 -1061
+ Misses 10266 9065 -1201
+ Partials 811 742 -69 ☔ View full report in Codecov by Sentry. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1、Refactor the method
ShuffleServerGrpcClient.requirePreAllocation, callinggetBlockingStub().requireBufferonly once.2、Try-catch
getBlockingStub().requireBuffer's exception, log the error, and returnFAILED_REQUIRE_ID.3、Refactor the log to make it more appropriate.
Why are the changes needed?
For #1456
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.