Code of Conduct
Search before asking
What would you like to be improved?
Currently, when we call the ShuffleServerGrpcClient.requirePreAllocation method, if the internal getBlockingStub().requireBuffer throws an exception, it is currently not being caught. We should catch the exception here, log the error, and return FAILED_REQUIRE_ID. This would make the ShuffleServerGrpcClient.requirePreAllocation method more pure. Also, we need to refactor the code to avoid calling getBlockingStub().requireBuffer multiple times.
How should we improve?
No response
Are you willing to submit PR?
Code of Conduct
Search before asking
What would you like to be improved?
Currently, when we call the
ShuffleServerGrpcClient.requirePreAllocationmethod, if the internalgetBlockingStub().requireBufferthrows an exception, it is currently not being caught. We should catch the exception here, log the error, and returnFAILED_REQUIRE_ID. This would make theShuffleServerGrpcClient.requirePreAllocationmethod more pure. Also, we need to refactor the code to avoid callinggetBlockingStub().requireBuffermultiple times.How should we improve?
No response
Are you willing to submit PR?