[Improvement] Better exception handling when calling requireBuffer using GRPC · Issue #1456 · apache/uniffle · GitHub
Skip to content

[Improvement] Better exception handling when calling requireBuffer using GRPC #1456

Description

@rickyma

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, when we call the ShuffleServerGrpcClient.requirePreAllocation method, if the internal getBlockingStub().requireBuffer throws an exception, it is currently not being caught. We should catch the exception here, log the error, and return FAILED_REQUIRE_ID. This would make the ShuffleServerGrpcClient.requirePreAllocation method more pure. Also, we need to refactor the code to avoid calling getBlockingStub().requireBuffer multiple times.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions