{{ message }}
Repository navigation
DRILL-4455: Depend on Apache Arrow - #398
Closed
StevenMPhillips wants to merge 5 commits into
Closed
StevenMPhillips wants to merge 5 commits into
StevenMPhillips wants to merge 5 commits into
Conversation
Contributor
Contributor
Author
|
I just rebased the patch and broke it up into 5 different patches. |
Contributor
|
I have two problems with this patch (apart from it being just too big to review)
|
Contributor
|
Sounds like we need to do some more work to mature and stabilize the Arrow code. Let's pick this up again once we've made more progress on that front. |
Contributor
|
@vrozov Since you are picking up Drillbuf design work, please advise on the plan for this PR. |
gparai
pushed a commit
to gparai/drill
that referenced
this pull request
Oct 10, 2018
…xpressions (apache#398) * Fixed pushing istrue and isfalse conditions. Added unit tests to test boolean conditions.
karthik-man
pushed a commit
to karthik-man/drill
that referenced
this pull request
Mar 14, 2019
…xpressions (apache#398) * Fixed pushing istrue and isfalse conditions. Added unit tests to test boolean conditions.
KazydubB
pushed a commit
to KazydubB/drill
that referenced
this pull request
Sep 25, 2019
…xpressions (apache#398) * Fixed pushing istrue and isfalse conditions. Added unit tests to test boolean conditions.
Member
ashevchuk123
pushed a commit
to mapr/incubator-drill
that referenced
this pull request
Oct 28, 2025
…xpressions (apache#398) * Fixed pushing istrue and isfalse conditions. Added unit tests to test boolean conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Remove the vector and memory modules
Replace most instances of TypeProtos.MajorType, TypeProtos.MinorType etc
with corresponding org.apache.arrow.types.Types class.
The code for serializing and deserializing vectors is still in the Drill code-base
and still uses the old TypeProtos classes. The class MajorTypeHelper is used
to convert between the two sets of classes.
The old load and getMetadata classes in ValueVector are now found in a corresponding
ValueVectorHelper class