{{ message }}
Repository navigation
Mavenized query-parse subproject - #1
Closed
antoniogarrote wants to merge 1 commit into
Closed
antoniogarrote wants to merge 1 commit into
antoniogarrote wants to merge 1 commit into
Conversation
Member
hnfgns
referenced
this pull request
in hnfgns/incubator-drill
Nov 6, 2015
…tream chain of bugs. Increments: 2288: Pt. 1 Core: Added unit test. [Drill2288GetColumnsMetadataWhenNoRowsTest, empty.json] 2288: Pt. 1 Core: Changed HBase test table #1's # of regions from 1 to 2. [HBaseTestsSuite] Also added TODO(DRILL-3954) comment about # of regions. 2288: Pt. 2 Core: Documented IterOutcome much more clearly. [RecordBatch] Also edited some related Javadoc. 2288: Pt. 2 Hyg.: Edited doc., added @OverRide, etc. [AbstractRecordBatch, RecordBatch] Purged unused SetupOutcome. Added @OverRide. Edited comments. Fix some comments to doc. comments. 2288: Pt. 3 Core&Hyg.: Added validation of IterOutcome sequence. [IteratorValidatorBatchIterator] Also: Renamed internal members for clarity. Added comments. 2288: Pt. 4 Core: Fixed a NONE -> OK_NEW_SCHEMA in ScanBatch.next(). [ScanBatch] (With nearby comments.) 2288: Pt. 4 Hyg.: Edited comments, reordered, whitespace. [ScanBatch] Reordered Added comments. Aligned. 2288: Pt. 4 Core+: Fixed UnionAllRecordBatch to receive IterOutcome sequence right. (3659) [UnionAllRecordBatch] 2288: Pt. 5 Core: Fixed ScanBatch.Mutator.isNewSchema() to stop spurious "new schema" reports (fix short-circuit OR, to call resetting method right). [ScanBatch] 2288: Pt. 5 Hyg.: Renamed, edited comments, reordered. [ScanBatch, SchemaChangeCallBack, AbstractSingleRecordBatch] Renamed getSchemaChange -> getSchemaChangedAndReset. Renamed schemaChange -> schemaChanged. Added doc. comments. Aligned. 2288: Pt. 6 Core: Avoided dummy Null.IntVec. column in JsonReader when not needed (MapWriter.isEmptyMap()). [JsonReader, 3 vector files] 2288: Pt. 6 Hyg.: Edited comments, message. Fixed message formatting. [RecordReader, JSONFormatPlugin, JSONRecordReader, AbstractMapVector, JsonReader] Fixed message formatting. Edited comments. Edited message. Fixed spurious line break. 2288: Pt. 7 Core: Added column families in HBaseRecordReader* to avoid dummy Null.IntVec. clash. [HBaseRecordReader] 2288: Pt. 8 Core.1: Cleared recordCount in OrderedPartitionRecordBatch.innerNext(). [OrderedPartitionRecordBatch] 2288: Pt. 8 Core.2: Cleared recordCount in ProjectRecordBatch.innerNext. [ProjectRecordBatch] 2288: Pt. 8 Core.3: Cleared recordCount in TopNBatch.innerNext. [TopNBatch] 2288: Pt. 9 Core: Had UnorderedReceiverBatch reset RecordBatchLoader's record count. [UnorderedReceiverBatch, RecordBatchLoader] 2288: Pt. 9 Hyg.: Added comments. [RecordBatchLoader] 2288: Pt. 10 Core: Worked around mismatched map child vectors in MapVector.getObject(). [MapVector] 2288: Pt. 11 Core: Added OK_NEW_SCHEMA schema comparison for HashAgg. [HashAggTemplate] 2288: Pt. 12 Core: Fixed memory leak in BaseTestQuery's printing. Fixed bad skipping of RecordBatchLoader.clear(...) and QueryDataBatch.load(...) for zero-row batches in printResult(...). Also, dropped suppression of call to VectorUtil.showVectorAccessibleContent(...) (so zero-row batches are as visible as others). 2288: Pt. 13 Core: Fixed test that used unhandled periods in column alias identifiers. 2288: Misc.: Added # of rows to showVectorAccessibleContent's output. [VectorUtil] 2288: Misc.: Added simple/partial toString() [VectorContainer, AbstractRecordReader, JSONRecordReader, BaseValueVector, FieldSelection, AbstractBaseWriter] 2288: Misc. Hyg.: Added doc. comments to VectorContainer. [VectorContainer] 2288: Misc. Hyg.: Edited comment. [DrillStringUtils] 2288: Misc. Hyg.: Clarified message for unhandled identifier containing period. 2288: Pt. 3 Core&Hyg. Upd.: Added schema comparison result to logging. [IteratorValidatorBatchIterator] 2288: Pt. 7 Core Upd.: Handled HBase columns too re NullableIntVectors. [HBaseRecordReader, TestTableGenerator, TestHBaseFilterPushDown] Created map-child vectors for requested columns. Added unit test method testDummyColumnsAreAvoided, adding new row to test table, updated some row counts. 2288: Pt. 7 Hyg. Upd.: Edited comment. [HBaseRecordReader] 2288: Pt. 11 Core Upd.: REVERTED all of bad OK_NEW_SCHEMA schema comparison for HashAgg. [HashAggTemplate] This reverts commit 0939660. 2288: Pt. 6 Core Upd.: Added isEmptyMap override in new (just-rebased-in) PromotableWriter. [PromotableWriter] Adjusted definition and default implementation of isEmptyMap (to handle MongoDB storage plugin's use of JsonReader). 2288: Pt. 6 Hyg. Upd.: Purged old atLeastOneWrite flag. [JsonReader] 2288: Pt. 14: Disabled newly dying test testNestedFlatten().
hnfgns
referenced
this pull request
in hnfgns/incubator-drill
Nov 9, 2015
…tream chain of bugs. Increments: 2288: Pt. 1 Core: Added unit test. [Drill2288GetColumnsMetadataWhenNoRowsTest, empty.json] 2288: Pt. 1 Core: Changed HBase test table #1's # of regions from 1 to 2. [HBaseTestsSuite] Also added TODO(DRILL-3954) comment about # of regions. 2288: Pt. 2 Core: Documented IterOutcome much more clearly. [RecordBatch] Also edited some related Javadoc. 2288: Pt. 2 Hyg.: Edited doc., added @OverRide, etc. [AbstractRecordBatch, RecordBatch] Purged unused SetupOutcome. Added @OverRide. Edited comments. Fix some comments to doc. comments. 2288: Pt. 3 Core&Hyg.: Added validation of IterOutcome sequence. [IteratorValidatorBatchIterator] Also: Renamed internal members for clarity. Added comments. 2288: Pt. 4 Core: Fixed a NONE -> OK_NEW_SCHEMA in ScanBatch.next(). [ScanBatch] (With nearby comments.) 2288: Pt. 4 Hyg.: Edited comments, reordered, whitespace. [ScanBatch] Reordered Added comments. Aligned. 2288: Pt. 4 Core+: Fixed UnionAllRecordBatch to receive IterOutcome sequence right. (3659) [UnionAllRecordBatch] 2288: Pt. 5 Core: Fixed ScanBatch.Mutator.isNewSchema() to stop spurious "new schema" reports (fix short-circuit OR, to call resetting method right). [ScanBatch] 2288: Pt. 5 Hyg.: Renamed, edited comments, reordered. [ScanBatch, SchemaChangeCallBack, AbstractSingleRecordBatch] Renamed getSchemaChange -> getSchemaChangedAndReset. Renamed schemaChange -> schemaChanged. Added doc. comments. Aligned. 2288: Pt. 6 Core: Avoided dummy Null.IntVec. column in JsonReader when not needed (MapWriter.isEmptyMap()). [JsonReader, 3 vector files] 2288: Pt. 6 Hyg.: Edited comments, message. Fixed message formatting. [RecordReader, JSONFormatPlugin, JSONRecordReader, AbstractMapVector, JsonReader] Fixed message formatting. Edited comments. Edited message. Fixed spurious line break. 2288: Pt. 7 Core: Added column families in HBaseRecordReader* to avoid dummy Null.IntVec. clash. [HBaseRecordReader] 2288: Pt. 8 Core.1: Cleared recordCount in OrderedPartitionRecordBatch.innerNext(). [OrderedPartitionRecordBatch] 2288: Pt. 8 Core.2: Cleared recordCount in ProjectRecordBatch.innerNext. [ProjectRecordBatch] 2288: Pt. 8 Core.3: Cleared recordCount in TopNBatch.innerNext. [TopNBatch] 2288: Pt. 9 Core: Had UnorderedReceiverBatch reset RecordBatchLoader's record count. [UnorderedReceiverBatch, RecordBatchLoader] 2288: Pt. 9 Hyg.: Added comments. [RecordBatchLoader] 2288: Pt. 10 Core: Worked around mismatched map child vectors in MapVector.getObject(). [MapVector] 2288: Pt. 11 Core: Added OK_NEW_SCHEMA schema comparison for HashAgg. [HashAggTemplate] 2288: Pt. 12 Core: Fixed memory leak in BaseTestQuery's printing. Fixed bad skipping of RecordBatchLoader.clear(...) and QueryDataBatch.load(...) for zero-row batches in printResult(...). Also, dropped suppression of call to VectorUtil.showVectorAccessibleContent(...) (so zero-row batches are as visible as others). 2288: Pt. 13 Core: Fixed test that used unhandled periods in column alias identifiers. 2288: Misc.: Added # of rows to showVectorAccessibleContent's output. [VectorUtil] 2288: Misc.: Added simple/partial toString() [VectorContainer, AbstractRecordReader, JSONRecordReader, BaseValueVector, FieldSelection, AbstractBaseWriter] 2288: Misc. Hyg.: Added doc. comments to VectorContainer. [VectorContainer] 2288: Misc. Hyg.: Edited comment. [DrillStringUtils] 2288: Misc. Hyg.: Clarified message for unhandled identifier containing period. 2288: Pt. 3 Core&Hyg. Upd.: Added schema comparison result to logging. [IteratorValidatorBatchIterator] 2288: Pt. 7 Core Upd.: Handled HBase columns too re NullableIntVectors. [HBaseRecordReader, TestTableGenerator, TestHBaseFilterPushDown] Created map-child vectors for requested columns. Added unit test method testDummyColumnsAreAvoided, adding new row to test table, updated some row counts. 2288: Pt. 7 Hyg. Upd.: Edited comment. [HBaseRecordReader] 2288: Pt. 11 Core Upd.: REVERTED all of bad OK_NEW_SCHEMA schema comparison for HashAgg. [HashAggTemplate] This reverts commit 0939660. 2288: Pt. 6 Core Upd.: Added isEmptyMap override in new (just-rebased-in) PromotableWriter. [PromotableWriter] Adjusted definition and default implementation of isEmptyMap (to handle MongoDB storage plugin's use of JsonReader). 2288: Pt. 6 Hyg. Upd.: Purged old atLeastOneWrite flag. [JsonReader] 2288: Pt. 14: Disabled newly dying test testNestedFlatten().
sudheeshkatkam
pushed a commit
to sudheeshkatkam/drill
that referenced
this pull request
May 26, 2017
1. Introduced an InMemoryStoreProvider with the ability to maintain a max capacity 2. DrillbitContext now explicitly has a profileStoreProvider that, by default, re-uses the general PersistentStoreProvider, unless it is InMemory, which is when apache#1 is used. 2. Cleanly separated out QueryProfileStoreContext 3. Converted literal values to constants within ExecConstants 4. Updated drill-module.conf for default capacity closes apache#834
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2017
1. Introduced an InMemoryStoreProvider with the ability to maintain a max capacity 2. DrillbitContext now explicitly has a profileStoreProvider that, by default, re-uses the general PersistentStoreProvider, unless it is InMemory, which is when #1 is used. 2. Cleanly separated out QueryProfileStoreContext 3. Converted literal values to constants within ExecConstants 4. Updated drill-module.conf for default capacity closes #834
ilooner
referenced
this pull request
in ilooner/drill
Jan 15, 2018
- Fixed TestVectorContainer.testContainerMerge failure.
HanumathRao
pushed a commit
to HanumathRao/drill
that referenced
this pull request
Jan 7, 2019
Currently, the WebServer side needs to process the entire set of results and stream it back to the WebClient. Since the WebUI does paginate results, we can load a larger set for pagination on the browser client and relieve pressure off the WebServer to host all the data (most of which will never be streamed to the browser). e.g. Fetching all rows from a 1Billion records table is impractical and can be capped at (say) 1K. Currently, the user has to explicitly specify LIMIT in the submitted query. An option is provided in the field to allow for this entry, and can be set to selected by default for the Web UI. The submitted query indicates that an auto-limiting wrapper was applied. [Update apache#1] Updated as per comments 1. Limit Wrapping Unchecked by default 2. Full List configuration of results [Update apache#2] Minor update [Update apache#3] Followup closes apache#1593
arina-ielchiieva
pushed a commit
to arina-ielchiieva/drill
that referenced
this pull request
Jan 10, 2019
Currently, the WebServer side needs to process the entire set of results and stream it back to the WebClient. Since the WebUI does paginate results, we can load a larger set for pagination on the browser client and relieve pressure off the WebServer to host all the data (most of which will never be streamed to the browser). e.g. Fetching all rows from a 1Billion records table is impractical and can be capped at (say) 1K. Currently, the user has to explicitly specify LIMIT in the submitted query. An option is provided in the field to allow for this entry, and can be set to selected by default for the Web UI. The submitted query indicates that an auto-limiting wrapper was applied. [Update apache#1] Updated as per comments 1. Limit Wrapping Unchecked by default 2. Full List configuration of results [Update apache#2] Minor update [Update apache#3] Followup closes apache#1593
luocooong
added a commit
to luocooong/drill
that referenced
this pull request
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the project can be built using Maven and tests are passing.
Added pom.xml file, changes in directory structure and minor code changes.