{{ message }}
fix(sdk): preserve V2Event name for SSE streams#34171
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effect@4.0.0-beta.83soStreamSse({ data })gives its JSON-string transport wrapper a distinct${Identifier}StreamOpenAPI identifierV2Eventand the wrapper isV2EventStreamV2Eventtype and add a regression test for the OpenAPI schema shapeWhy
StreamSse({ data: EventSchema })wraps the SSEdata:field withSchema.fromJsonString(EventSchema). The wrapper was resolving to the same identifier as the decoded schema, so the string wrapper claimedV2Eventand the real union was emitted asV2Event1.This fixes the collision at the Effect schema source instead of post-processing opencode's SDK output.
Validation
cd packages/opencode && bun test test/server/httpapi-public-openapi.test.tscd packages/opencode && bun typecheckcd packages/client && bun test test/effect.test.tscd packages/client && bun run generate && bun run check:generated./packages/sdk/js/script/build.tscd packages/sdk/js && bun tsccd packages/tui && bun typecheckgrep -rn '\bV2Event1\b' packages/sdk/js/srcreturns no matches