{{ message }}
fix(sdk): type SSE event payloads#34170
Closed
opencode-agent[bot] wants to merge 1 commit into
Closed
Conversation
Patch Effect OpenAPI generation so data-mode SSE responses expose their JSON payload schema instead of the raw data-line string wrapper. Regenerate legacy SDK types so V2Event and SessionDurableEvent remain the public payload unions. Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
bc9c086 to
6dbd516
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
StreamSseresponses so the OpenAPI media schema is the JSON payload schema, not the raw SSEdata:line string wrapperx-effect-stream) intact for clients that need transport semanticsV2EventandSessionDurableEventremain the public payload unionsV2Event1name toV2EventValidation
contentSchemastring wrapper/api/eventreferences#/components/schemas/V2Event, onlyV2Eventexists, and it is the union;/api/session/{sessionID}/eventreferencesSessionDurableEventbun run buildfrompackages/sdk/jsbun typecheckfrompackages/sdk/jsbun typecheckfrompackages/tuibun run check:generatedfrompackages/clientbun turbo typecheck(29/29 tasks)